-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OnnxConversion failure in GPTJ example #469
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My modification may not be robust. If you have any suggestions, please feel free to raise them. |
trajepl
reviewed
Aug 8, 2023
yuwenzho
force-pushed
the
yuwenzho/fix_gptj
branch
2 times, most recently
from
August 9, 2023 02:09
2a6de0b
to
507caa7
Compare
guotuofeng
reviewed
Aug 9, 2023
yuwenzho
force-pushed
the
yuwenzho/fix_gptj
branch
from
August 9, 2023 06:06
507caa7
to
daebe72
Compare
jambayk
reviewed
Aug 9, 2023
jambayk
reviewed
Aug 9, 2023
jambayk
reviewed
Aug 9, 2023
Signed-off-by: yuwenzho <[email protected]>
Signed-off-by: yuwenzho <[email protected]>
yuwenzho
force-pushed
the
yuwenzho/fix_gptj
branch
from
August 9, 2023 07:28
daebe72
to
293fcdb
Compare
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Thanks for the fix! The failing test is not because of this PR. We will look into solving it and then we can retrigger the ci after the fix. |
jambayk
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
summary:
Skip removing past_key_values in dummy input in OnnxConversion, which is required for hf model with past.
Details:
GPTJ example failed in OnnxConversion with error:
RuntimeError: The size of tensor a (8) must match the size of tensor b (18) at non-singleton dimension 3
To quickly reproduce the error:
The error is caused in conversion.py#L115-L124.
Checklist before requesting a review
pre-commit run --all-files
(Optional) Issue link