Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a BERT example using Intel Neural Compressor SmoothQuant #411

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

yuwenzho
Copy link
Contributor

Describe your changes

Add a BERT example using Intel® Neural Compressor SmoothQuant.
Add an introduction of Intel® Neural Compressor SmoothQuant to the README.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Format your code by running pre-commit run --all-files
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.

(Optional) Issue link

@guotuofeng
Copy link
Collaborator

do we need enable it in CI pipeline?

@yuwenzho
Copy link
Contributor Author

do we need enable it in CI pipeline?

Yes, we do need to enable it in the CI pipeline. Could you please provide some guidance or suggestions on how to do this? It would be of great help.

@yuwenzho yuwenzho force-pushed the yuwenzho/inc_sq_example branch from d9d7726 to 87fead6 Compare July 13, 2023 08:27
@yuwenzho
Copy link
Contributor Author

I enabled bert_inc_ptq_cpu and bert_inc_smoothquant_ptq_cpu in CI pipeline

trajepl
trajepl previously approved these changes Jul 14, 2023
@@ -23,12 +23,15 @@ def setup():
@pytest.mark.parametrize("search_algorithm", ["tpe"])
@pytest.mark.parametrize("execution_order", ["joint"])
@pytest.mark.parametrize("system", ["local_system", "aml_system", "docker_system"])
@pytest.mark.parametrize("olive_json", ["bert_ptq_cpu.json"])
@pytest.mark.parametrize("olive_json", ["bert_ptq_cpu.json", "bert_inc_ptq_cpu.json", "bert_inc_smoothquant_ptq_cpu.json"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emm, if so, current Bert pipeline will run with about 3x times than before(about 1h). As it is only test the inc quantizaion passes, maybe we do not need to run the complete E2E tests?

I believe INC team already had their tests but not in Olive just like other ONNX passes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestion. I removed Bert INC test from the CI pipeline. All INC-related examples are tested internally by INC team.

@trajepl trajepl dismissed their stale review July 14, 2023 05:43

wrong click

@yuwenzho yuwenzho force-pushed the yuwenzho/inc_sq_example branch from 87fead6 to 1619952 Compare July 14, 2023 06:13
@trajepl
Copy link
Contributor

trajepl commented Jul 14, 2023

/azp run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 411 in repo microsoft/Olive

@trajepl
Copy link
Contributor

trajepl commented Jul 14, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@trajepl trajepl merged commit 0c5f7bc into microsoft:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants