-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HfConfig::dataset references in examples and tests #1113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the changes look good to me. Just want to confirm with @trajepl that will be okay/safe to remove the feature at
if self.hf_config.dataset: |
Since HFConfig::dataset will be removed after this.
Will approve again once Jiapeng gives his response on the question above.
The function P.S. This is my first impression from looking at the function implementation. I am guessing the call-site for the function itself has access to the specific |
231d239#diff-3fbc96d0a23f27fb63d646e8949b46cf42cb0aedcfa10e8caca0f331f0a119e2 |
@trajepl , @jambayk , @guotuofeng Rebased and ready for re-re-review. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
69cd0ab
to
ad20783
Compare
Remove references to HFConfig::dataset from input model in all examples and tests. Moved the references to the dataset into data_configs and updated references accordingly. This change also eliminates the need for the constant __input_model_data_config__.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…1113) ## Remove HfConfig::dataset references in examples and tests Remove references to HFConfig::dataset from input model in all examples and tests. Moved the references to the dataset into data_configs and updated references accordingly. This change also eliminates the need for the constant __input_model_data_config__. ## Checklist before requesting a review - [ ] Add unit tests for this change. - [x] Make sure all tests can pass. - [ ] Update documents if necessary. - [x] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
Remove HfConfig::dataset references in examples and tests
Remove references to HFConfig::dataset from input model in all examples and tests. Moved the references to the dataset into data_configs and updated references accordingly. This change also eliminates the need for the constant input_model_data_config.
Checklist before requesting a review
lintrunner -a
(Optional) Issue link