🇶🇦 Fix Errors from code ql scanning #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
trajepl
changed the title
|
Check the CodeQL scanning results: |
guotuofeng
reviewed
Apr 16, 2024
olive/passes/pytorch/lora.py
Outdated
| @@ -588,6 +588,7 @@ def train_and_save_new_model( | |||
| :param output_model_path: The path to save the output model to. | |||
| :return: The output model handler. | |||
| """ | |||
| allow_tf32 = None | |||
There was a problem hiding this comment.
we can ignore the warning here since allow_tf32 is only defined for cuda.
There was a problem hiding this comment.
This kind of isssues are shown as errors.
There was a problem hiding this comment.
I mean we might need find some ways to ignore/disable this errors since we might not be able fix all errors.
trajepl
force-pushed
the
jiapli/code_ql_fix_1
branch
from
2652ade to
06d49a6
Compare
guotuofeng
previously approved these changes
Apr 16, 2024
This reverts commit 50770c6.
guotuofeng
approved these changes
Apr 16, 2024
DavitGrigoryan132
pushed a commit
to DavitGrigoryan132/Olive
that referenced
this pull request
Aug 14, 2024
## Describe your changes Fix partial issues from code ql scanning ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fix partial issues from code ql scanning
Checklist before requesting a review
lintrunner -a(Optional) Issue link