-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some bugs #404
Fix some bugs #404
Conversation
…default NpmMutators.
…m/q would create pkg:npm/. as a squat. Add test for it.
…the @. Added test case for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment. Probably fine either way but something to consider.
…ests to validate it. Fixed other test I wrote.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One new comment on using Convert.ToChar vs just taking the first character via indexing. I'm not totally familiar with Convert.ToChar
…ex 0 of the string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
RemoveSeparatedSectionMutator
to the list of defaults, but remove it specifically for NPM.pkg:npm/q
would makepkg:npm/.
orpkg:npm/typescript
could makepkg:npm/-
@
resulting in mutations likepkg:npm/-%40types/node
when that isn't possible. It now adds after the@
but before the namespace begins, resulting inpkg:npm/%40-types/node