Remove source packaged in NuGet for 2.1 Release #6251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 9, 2019 13:52
…th issue. This source will return as part of 2.2 release
…into prerelease/2.1.0_bugs/removeSourceFor21Release
david-c-kline
approved these changes
Oct 9, 2019
keveleigh
reviewed
Oct 9, 2019
| @@ -30,20 +30,21 @@ | |||
| <file src="..\Plugins\**\Microsoft.MixedReality.Toolkit.dll*" target="Plugins\" /> | |||
| <file src="..\Plugins\**\Microsoft.MixedReality.Toolkit.pdb*" target="Plugins\" /> | |||
| <file src="..\Plugins\**\Microsoft.MixedReality.Toolkit.Gltf.*" target="Plugins\" /> | |||
| <file src="..\..\Assets\MixedRealityToolkit\**\*.cs" target="contentFiles\any\any\.PkgSrc\MRTK\MixedRealityToolkit" /> | |||
| <!--Source commented as part of 2.1 release due to lack of support for long paths in N4U, and there is support for using source publicly yet.--> | |||
There was a problem hiding this comment.
Is this correct?
Suggested change
| <!--Source commented as part of 2.1 release due to lack of support for long paths in N4U, and there is support for using source publicly yet.--> | |
| <!--Source commented as part of 2.1 release due to lack of support for long paths in N4U, and there is not support for using source publicly yet.--> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with NugetForUnity with long paths, and the source is deeply nested in the NuGet package. This change excludes the source from being packaged, to avoid that issue for the time being. In 2.2 this will return, as well as a supported scenario for using this source to debug the binaries in the package.