FpsDisplay fixes #382
Merged
FpsDisplay fixes #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenHodgson
changed the title
|
Interesting, it looks this was caused by losing X as a pivot axis in 37247d9#diff-40903bdeebaf71c08a776607e5cb91e0 Was that intentional @maxouellet ? |
|
@keveleigh if I remember correctly, it was removed by an internal Microsoft team because it didn't work, or at least didn't have the behavior that one would expect (or didn't serve much purpose as implemented). I'm completely OK with adding it back if we get it to work properly and if it is useful. |
|
The extra axis wasn't required for the fps prefab to work properly. |
|
@maxouellet Sounds good! I'll create an Issue and take a look at it. @HodgsonSDAS It might not be required for the FPS prefab to work, but Billboard is a normally used component as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed redundant text mesh.
Updated prefab's pivot to be pre-selected to Y axis. (was unset previously)