Fix pointer line visibility when switching the active controller #2670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keveleigh
added
Ready for Review
Legacy (HoloToolkit)
david-c-kline
approved these changes
Aug 30, 2018
StephenHodgson
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When one controller is using the glTF controller model and the other isn't, the pointing ray doesn't properly disable itself when it doesn't find anything to attach to. This is because we update the handedness, then in the refresh code check to make sure the handedness is the same as the currently tracked controller before sending the controller lost event.
This change forces the previous controller to be lost, regardless of the current handedness.
Changes