Minor keyboard fixes #2522
Merged
Minor keyboard fixes #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keveleigh
added
Ready for Review
Legacy (HoloToolkit)
david-c-kline
approved these changes
Jul 31, 2018
fieldsJacksonG
approved these changes
Jul 31, 2018
| @@ -253,7 +253,7 @@ protected override void Awake() | |||
|
|
|||
| // Setting the keyboardType to an undefined TouchScreenKeyboardType, | |||
| // which prevents the MRTK keyboard from triggering the system keyboard itself. | |||
| InputField.keyboardType = (TouchScreenKeyboardType)(-1); | |||
| InputField.keyboardType = (TouchScreenKeyboardType)(int.MaxValue); | |||
There was a problem hiding this comment.
MinValue? (technically you might be able to connect a lot of keyboards, but you can't connect negative keyboards!)
There was a problem hiding this comment.
This was changed because, when building for UWP XAML, it tries to cast the value (previously -1) into a uint when doing the enum conversion and throws an error. See: #2384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Instead of trying to case a negative int and failing on XAML, now we cast a large, still invalid, number.
Also, disables the Toolkit keyboard on platforms that support a system keyboard.
Changes