Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better example for custom Icons for AppBar #2314

Merged
merged 2 commits into from
Jun 26, 2018
Merged

Better example for custom Icons for AppBar #2314

merged 2 commits into from
Jun 26, 2018

Conversation

brean
Copy link

@brean brean commented Jun 17, 2018

Overview

Some icons for the AppBar instead of the generic ObjectCollectionScatter, to look a bit more like the version from the Holograms app

Changes

@brean brean mentioned this pull request Jun 17, 2018
@@ -0,0 +1,236 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why svg instead of png?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see you included both.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I added the original files, makes it easier for others to either modify existing icons or add new icons based on these.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll def use TextMeshPro to make the default icon pack for vNEXT.

StephenHodgson
StephenHodgson previously approved these changes Jun 17, 2018
@StephenHodgson StephenHodgson changed the title Icons for AppBar Better example for custom Icons for AppBar Jun 17, 2018
@keveleigh keveleigh requested a review from cre8ivepark June 19, 2018 00:10
@david-c-kline
Copy link

@cre8ivepark should review the look of these new icons

@cre8ivepark
Copy link
Contributor

Thanks! @brean We were not able to include icon glyph font files and images of the glyphs since we cannot publish them in the open-source projects. (font license/design patent issue).
We provide HoloLens MDL font from Dev Center with proper EULA file. Developers can manually import into Unity and generate the texture from this font file.
https://docs.microsoft.com/en-us/windows/uwp/design/downloads/

I agree that we need better documentation for this & tools. (something that can automatically generate icon texture from the font file - we had this feature in MixedRealityDesignLabs. Needs porting work)

I'll clone your repo and check out your icon design today. Thank you!
Yoon

@StephenHodgson
Copy link
Contributor

StephenHodgson commented Jun 19, 2018

@cre8ivepark if we were to generate the icons with a tool like TextMeshPro without including the source font itself in the project, would that satisfy the licensing constraints?

The end result would just be a texture.

Copy link
Contributor

@cre8ivepark cre8ivepark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out the design. Since your design is very close to the original design, I think it would be better to just use the original design from HoloLens MDL font glyphs. I'll apply the updated texture to your repository this weekend. Thanks!

@cre8ivepark
Copy link
Contributor

cre8ivepark commented Jun 25, 2018

@brean , I applied changes to your repository. Thank you!

  • Updated textures to the original design.
  • Changed the location of the textures to existing HoloToolkit/UX/Textures/Icons. Textures under HoloToolkit-Examples folder will break the app bar when the user doesn't have HoloToolkit-Examples folder.
  • Removed SVG files. People can use existing icon texture (512x512) png file and HoloLens MDL font as a template.
  • Updated icon font material to use emission color. (icon was shaded depending on the direction, by the lighting condition)

2018-06-25 06_54_07-unity 2017 2 1p2 64bit - boundingboxgizmoexample unity - mrtk-breen - universa
2018-06-25 06_54_24-unity 2017 2 1p2 64bit - boundingboxgizmoexample unity - mrtk-breen - universa
2018-06-25 06_54_34-unity 2017 2 1p2 64bit - boundingboxgizmoexample unity - mrtk-breen - universa

@david-c-kline david-c-kline merged commit 79d2666 into microsoft:june18_dev Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants