-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better example for custom Icons for AppBar #2314
Conversation
@@ -0,0 +1,236 @@ | |||
<?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
<!-- Created with Inkscape (http://www.inkscape.org/) --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why svg instead of png?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see you included both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I added the original files, makes it easier for others to either modify existing icons or add new icons based on these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll def use TextMeshPro to make the default icon pack for vNEXT.
@cre8ivepark should review the look of these new icons |
Thanks! @brean We were not able to include icon glyph font files and images of the glyphs since we cannot publish them in the open-source projects. (font license/design patent issue). I agree that we need better documentation for this & tools. (something that can automatically generate icon texture from the font file - we had this feature in MixedRealityDesignLabs. Needs porting work) I'll clone your repo and check out your icon design today. Thank you! |
@cre8ivepark if we were to generate the icons with a tool like TextMeshPro without including the source font itself in the project, would that satisfy the licensing constraints? The end result would just be a texture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked out the design. Since your design is very close to the original design, I think it would be better to just use the original design from HoloLens MDL font glyphs. I'll apply the updated texture to your repository this weekend. Thanks!
…ple folder dependency. Removed SVG files.
@brean , I applied changes to your repository. Thank you!
|
Overview
Some icons for the AppBar instead of the generic ObjectCollectionScatter, to look a bit more like the version from the Holograms app
Changes