HostTransform for TwoHandManipulatable #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated TwoHandManipulatable to use HostTransform for BoundingBoxRig
|
There will be some porting from master into vNext. Not 100% sure if we will use dev as a stepping stone due to the fact that it will be locked shortly and would require two passes at the namespace / folder structure. |
StephenHodgson
approved these changes
May 22, 2018
|
Looks like there have definitely been some divergence between the branches in this file. I don't see this change in master though: https://github.com/Microsoft/MixedRealityToolkit-Unity/blob/may18_dev/Assets/HoloToolkit/Input/Scripts/Utilities/Interactions/TwoHandManipulatable.cs#L120 |
|
@Jarodshow What does this change do/fix? Looks like this is a good change, so I'm mostly curious how the bug manifests itself. |
|
Not a bug, just a way to specify a different transform position |
keveleigh
approved these changes
May 23, 2018
This was referenced Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updated TwoHandManipulatable to use
HostTransformforBoundingBoxRig.