Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[May18] Surface Magnetism + Spatial Processing example scene #2113

Merged

Conversation

cre8ivepark
Copy link
Contributor

Overview

Adding an example scene which shows how to make objects smoothly align with the surfaces using SolverSurfaceMagnetism. Based on existing SpatialProcessing example scene, added a plane with MRTK logo with SolverSurfaceMagnetism script.

Demo video

https://gfycat.com/PitifulRareKodiakbear

Changes

  • No code changes or updates.
  • Added new scene SpatialProcessingSurfaceMagnetism.unity

Readme

SpatialProcessingSurfaceMagnetism.md

@@ -72,7 +73,7 @@ Material:
- _WireThickness: 100
- _ZWrite: 1
m_Colors:
- _BaseColor: {r: 0, g: 0, b: 0, a: 1}
- _BaseColor: {r: 0.0036224083, g: 0.24982113, b: 0.49264705, a: 1}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be editing the base material, or using a copy for our example?

May need to revert.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Why was the color changed?

Copy link
Contributor Author

@cre8ivepark cre8ivepark May 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I wanted to update default white to more similar to what we have in Fragments (changed it to blue)
Original:
2018-05-17 10_05_49-photos
Updated:
2018-05-17 10_06_13-photos

2018-05-17 10_14_00-

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can duplicate with a new name 'WireframeBlue.mat' if we want. and assign it to SpatialMapping prefab as a default material.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do duplicate the material. Changing the color can cause confusion with customers.

Thanks!

Copy link

@david-c-kline david-c-kline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only issue I see is the change to Wireframe.mat

…ted scene with new material. Adding missing meta file for the readme.
@cre8ivepark
Copy link
Contributor Author

@davidkline-ms Reverted Wireframe.mat to black & white. and added WireframeBlue.mat. Thanks!

@david-c-kline david-c-kline requested a review from keveleigh May 17, 2018 17:32
@cre8ivepark
Copy link
Contributor Author

Applied same updates to the PR for Dev branch #2114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants