Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2103 - allow unsafe code #2104

Merged
merged 2 commits into from
May 15, 2018
Merged

fix #2103 - allow unsafe code #2104

merged 2 commits into from
May 15, 2018

Conversation

david-c-kline
Copy link

@david-c-kline david-c-kline commented May 15, 2018

Add csc.* to fix Unity not enabling Allow Unsafe Code in the generated projects when building for the .NET Backend.

Tested on Unity versions:

  • 2017.1.3p4
  • 2017.2.1p2
  • 2017.4.3f1

Fixes: #2103

@keveleigh
Copy link
Contributor

We may need to use both. Does this work with IL2CPP?

image

@david-c-kline
Copy link
Author

@keveleigh, good question. i'll give it a try

@david-c-kline
Copy link
Author

verified that with BOTH files present, Unity successfully compiles the dll with IL2CPP.

@david-c-kline
Copy link
Author

Updated PR description to match the current contents.

@StephenHodgson
Copy link
Contributor

Do we also need to make sure this file gets included into the asset package?

What happens if someone has a file like this already declared?

@david-c-kline
Copy link
Author

@StephenHodgson,

I will be adding these files to the asset package for the May release. If the user has one, the package importer should show it as already there (and not override)

@StephenHodgson
Copy link
Contributor

StephenHodgson commented May 15, 2018

the package importer should show it as already there (and not override)

that's not exactly how it works. It'll only override if the meta file id is the same.

@david-c-kline
Copy link
Author

We had been shipping .rsp files in earlier releases. Is the concern that ours may overwrite an existing rsp?

@StephenHodgson
Copy link
Contributor

no, mostly if they collide, but then again, if people are using this file they most likely know how to handle conflicts with it.

@david-c-kline david-c-kline merged commit dc21720 into microsoft:may18_dev May 15, 2018
@david-c-kline david-c-kline deleted the investigateUnsafeCode branch May 16, 2018 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants