'Cherry pick' of work previously committed to Dev_Working with PR #1870: #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rosoft#1870: Adding GripPosition and GripRotation to SupportedInputInfo and adding support to WSA input source and related classes * added new input info types to SupportedInputInfo; PointerPosition and PointerRotation have equivalence to, and deprecate, Position and Rotation; GripPosition and GripRotation extend the bitfield * InteractionInputSource now reports support for grip position & rotation; replaced deprecated type id's with replacements * replacing use of deprecated SupportedInputInfo types in simple use cases * adding support for GripPosition/Rotation, and updating uses of now-deprecated Position/Rotation type enums, in CustomInputSource and DebugInteractionSourcePose * replaced "summary"-tag comments with [Obsolete] attributes to denote changes to enum ids
StephenHodgson
approved these changes
May 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adding GripPosition and GripRotation to SupportedInputInfo and adding support to WSA input source and related classes, originally submitted in Dev_Working_Branch as PR #1870. Now 'cherry picked' and submitted for the May18 release in the original HoloToolkit hierarchy.
Changes
added new input info types to SupportedInputInfo;
PointerPosition and PointerRotation have equivalence to, and deprecate, Position and Rotation;
GripPosition and GripRotation extend the bitfield
InteractionInputSource now reports support for grip position & rotation; replaced deprecated type id's with replacements
replacing use of deprecated SupportedInputInfo types in simple use cases
adding support for GripPosition/Rotation, and updating uses of now-deprecated Position/Rotation type enums, in CustomInputSource and DebugInteractionSourcePose
replaced "summary"-tag comments with [Obsolete] attributes to denote changes to enum ids