[May18] Cursor light fix (and other minor fixes) #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-c-kline
previously approved these changes
May 2, 2018
| @@ -29,6 +29,7 @@ public class Billboard : MonoBehaviour | |||
| /// The axis about which the object will rotate. | |||
| /// </summary> | |||
| [Tooltip("Specifies the axis about which the object will rotate.")] | |||
| [SerializeField] | |||
| private PivotAxis pivotAxis = PivotAxis.XY; | |||
There was a problem hiding this comment.
See #2036 (comment)
There was a problem hiding this comment.
This one is private.
There was a problem hiding this comment.
Then the other should be too.
There was a problem hiding this comment.
I saw you did it already 😉
StephenHodgson
approved these changes
May 2, 2018
david-c-kline
approved these changes
May 2, 2018
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some minor updates that were found while updating the Academy courses to the most recent Toolkit release.
Partner PR to #2036.
Changes