fix fpsdisplay perf, add comments and frame range #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-c-kline
requested review from
SimonDarksideJ,
keveleigh and
StephenHodgson
| [Tooltip("How many frames should we consider into our average calculation?")] | ||
| [SerializeField] | ||
| [Range(1, 300)] |
There was a problem hiding this comment.
it's 5 seconds at 60fps. no reason other than that. this field feels like it needs a range value. do you have a suggested max number of frames?
StephenHodgson
approved these changes
Apr 23, 2018
|
@davidkline-ms is there a PR for dev? |
|
@StephenHodgson, thanks for keeping me honest. There will be one today :) |
This was referenced Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FpsDisplay was repeatedly fetching components if the user did not use both a TextMesh and a uGui Text component. Fixed by adding Start() and calling InitBuffer there instead of in Update.
Also added a range (1-300) to the number of frames used to calculate FPS and some documentation comments.
Fixes: #1913 .