Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Patch4] fix #1827 (disabled state handling) #1919

Merged
merged 1 commit into from
Apr 5, 2018
Merged

[Patch4] fix #1827 (disabled state handling) #1919

merged 1 commit into from
Apr 5, 2018

Conversation

david-c-kline
Copy link

  • changed if (enabled) -> if (enabled && !m_disabled) in OnInputDown, OnInputUp and OnInputClicked.
  • added encapsulation of serialized fields per vNext coding style guidelines

Fixes: #1827.

@david-c-kline david-c-kline changed the title fix #1827 (disabled state handling) [Patch4] fix #1827 (disabled state handling) Apr 5, 2018
@david-c-kline david-c-kline merged commit ccceaf9 into microsoft:Patch4_Dev Apr 5, 2018
@david-c-kline david-c-kline deleted the ux1827 branch April 5, 2018 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenHodgson StephenHodgson StephenHodgson approved these changes

@Railboy Railboy Awaiting requested review from Railboy

@cre8ivepark cre8ivepark Awaiting requested review from cre8ivepark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-c-kline @StephenHodgson