Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc Cleanup #1897

Merged
merged 3 commits into from
Apr 18, 2018
Merged

Misc Cleanup #1897

merged 3 commits into from
Apr 18, 2018

Conversation

StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented Mar 30, 2018 •
edited
Loading

Overview

Removed compile warnings and cleaned up the files I touched to reflect the coding guidelines.

Breaking Changes

  • Moved some public enums and a struct into their own files.

TODO

  • Go through prefabs and examples to make sure there aren't any missing references.

SimonDarksideJ
SimonDarksideJ previously approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@SimonDarksideJ SimonDarksideJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

david-c-kline
david-c-kline previously approved these changes Apr 9, 2018
View reviewed changes
@StephenHodgson StephenHodgson deleted the dev-misc branch April 13, 2018 00:19
@StephenHodgson StephenHodgson restored the dev-misc branch April 13, 2018 00:19
@StephenHodgson
Copy link
Contributor Author

@davidkline-ms @SimonDarksideJ addressed conflicts

SimonDarksideJ
SimonDarksideJ approved these changes Apr 13, 2018
View reviewed changes
Copy link
Contributor

@SimonDarksideJ SimonDarksideJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@keveleigh keveleigh merged commit d7c894d into microsoft:Dev_Working_Branch Apr 18, 2018
@StephenHodgson StephenHodgson deleted the dev-misc branch April 20, 2018 15:47
@keveleigh keveleigh mentioned this pull request Jul 10, 2018
Closed
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keveleigh keveleigh keveleigh approved these changes

@SimonDarksideJ SimonDarksideJ SimonDarksideJ approved these changes

@david-c-kline david-c-kline david-c-kline left review comments

@johnppella johnppella Awaiting requested review from johnppella

Assignees
No one assigned
Labels
BREAKING CHANGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StephenHodgson @SimonDarksideJ @keveleigh @david-c-kline