[Dev→master] Billboard updates #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Billboard Fixes microsoft#1672, fixes microsoft#383, fixes microsoft#208.
david-c-kline
previously approved these changes
Mar 21, 2018
| @@ -22,7 +29,7 @@ public class Billboard : MonoBehaviour | |||
| /// The axis about which the object will rotate. | |||
| /// </summary> | |||
| [Tooltip("Specifies the axis about which the object will rotate.")] | |||
| public PivotAxis PivotAxis = PivotAxis.Free; | |||
| public PivotAxis PivotAxis = PivotAxis.XY; | |||
There was a problem hiding this comment.
Let's follow the new guidelines wrt fields.
There was a problem hiding this comment.
Good catch! Updated both your comments.
| @@ -22,7 +29,7 @@ public class Billboard : MonoBehaviour | |||
| /// The axis about which the object will rotate. | |||
| /// </summary> | |||
| [Tooltip("Specifies the axis about which the object will rotate.")] | |||
| public PivotAxis PivotAxis = PivotAxis.Free; | |||
| public PivotAxis PivotAxis = PivotAxis.XY; | |||
|
|
|||
| [Tooltip("Specifies the target we will orient to. If no Target is specified the main camera will be used.")] | |||
david-c-kline
approved these changes
Mar 22, 2018
StephenHodgson
approved these changes
Mar 22, 2018
There was a problem hiding this comment.
I'm sure @SimonDarksideJ might have something to say about that Enum, but I don't mind 😛
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #1817.
Overview
Added support for all combinations of axes. I rearranged the enum to preserve existing behavior (the previous Free was actually only the X and Y axes).
Changes