-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new sample scenes #11710
Add new sample scenes #11710
Conversation
Removed scripts from MRTK2 version which are not needed to demonstrate this functionality.
The previous material would turn black on one side depending what angle you looked at it from.
Using MRTKLineVisual and BezierDataProvider. Note that the MRTK2 version of the LineExamples sample scene had more examples because more data providers were implemented. Additionally, the MRTKLineVisual ties the lines to an Interactor, unlike the MRTK2 scripts.
…mand to reset the experience
… font size of dialog panels larger.
MRH3-15 DwellExample
…cessary scope braces
…/shaynie/sampleSceneWork
UnityProjects/MRTKDevTemplate/Assets/Scripts/BoundsControlRuntimeExample.cs
Outdated
Show resolved
Hide resolved
UnityProjects/MRTKDevTemplate/Assets/Scripts/EyeTracking/ChangeRenderMode.cs
Show resolved
Hide resolved
UnityProjects/MRTKDevTemplate/Assets/Scripts/InteractorBehaviorControls.cs
Show resolved
Hide resolved
UnityProjects/MRTKDevTemplate/Assets/Scripts/InteractorBehaviorControls.cs
Show resolved
Hide resolved
UnityProjects/MRTKDevTemplate/Assets/Scripts/SpeechKeywordRecognitionHandler.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good... I agree with Marlena's comments.
For the samples, it's probably ok to leave some summary blocks out...but add the following to the top and bottom of the sample files if you do:
// Disable "missing XML comment" warning for sample. While nice to have, this documentation is not required for samples. #pragma warning disable CS1591
#pragma warning restore CS1591
This will prevent warnings for missing XML documentation during the build process.
…kit-Unity into user/shaynie/sampleSceneWork # Conflicts: # UnityProjects/MRTKDevTemplate/Assets/Scenes/SolverExamples.unity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sign-off ... assuming @marlenaklein-msft does as well
Overview
Changes
Verification