Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing XML documentation warnings in MRTK3 and some variable name spelling fixes, first pass #11706

Merged
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
bdcfaf1
Add summary blocks and renamed some variables so they are actual words
AMollis Jul 12, 2023
dd0a16b
Merge branch 'mrtk3' into user/amollis/mrtk3/more-summary-block-fixes
AMollis Jul 12, 2023
9a3d2f5
summary blocks
AMollis Jul 13, 2023
2d4f9e0
fix compile error
AMollis Jul 13, 2023
0a50f19
Disable test warnings XML comments
AMollis Jul 13, 2023
a0cad08
Disabling missing xml documenation warning in data package
AMollis Jul 13, 2023
9c8d773
disable warnings on data package
AMollis Jul 13, 2023
29485e3
Adjust warning disablement
AMollis Jul 13, 2023
44b8bb5
Updating XML documentation
AMollis Jul 14, 2023
4ce49a9
more documentation updates
AMollis Jul 14, 2023
21468fa
More documentation changes.
AMollis Jul 14, 2023
b4ee853
Minor change
AMollis Jul 14, 2023
416dde6
More changes
AMollis Jul 14, 2023
96d25eb
More changes
AMollis Jul 14, 2023
650d9f2
More changes
AMollis Jul 14, 2023
72b090f
More changes
AMollis Jul 14, 2023
6a4619a
addressing PR feedback
AMollis Jul 14, 2023
958f611
find changes?
AMollis Jul 14, 2023
d17269d
more changes
AMollis Jul 15, 2023
a1ada38
More changes
AMollis Jul 15, 2023
9bc9871
core and diagnostic packages errors should be fixed
AMollis Jul 15, 2023
f00254a
core package is not done yet ~100 more warnings to go...
AMollis Jul 15, 2023
9db6740
More updates
AMollis Jul 15, 2023
5570024
more updates
AMollis Jul 15, 2023
522c056
more changes
AMollis Jul 15, 2023
a6626f7
More changes
AMollis Jul 15, 2023
2970947
fixing validation error
AMollis Jul 16, 2023
b5ce3fb
Now core package XML documentation warnings have been addressed. 48…
AMollis Jul 16, 2023
be17bcf
Fixing True/False comments
AMollis Jul 16, 2023
15b68d3
Fixing more XML documentations.
AMollis Jul 16, 2023
49814f3
some more fixes
AMollis Jul 17, 2023
c9f8c48
more changes
AMollis Jul 17, 2023
a91c50a
More changes
AMollis Jul 17, 2023
861507b
Fixing "experimental" comment
AMollis Jul 17, 2023
9479f81
more changes
AMollis Jul 17, 2023
699e3f4
clarifying comment
AMollis Jul 17, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ public class DataControllerTest : DataControllerGOBase

private IDataSource _dataSource;

/// <summary>
/// A Unity event function that is called when the script component has been enabled.
/// </summary>
private void OnEnable()
{
GetNearestDataSource("data");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ public override IDataSource AllocateDataSource()
return new DataSourceObjects();
}

/// <summary>
/// A Unity event function that is called every frame, if this object is enabled.
/// </summary>
private void Update()
{
_counter++;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ protected override void InitializeDataSource()
_time = secondsBetweenFetches;
}

/// <summary>
/// A Unity event function that is called every frame, if this object is enabled.
/// </summary>
private void Update()
{
_time += Time.deltaTime;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ protected override void InitializeDataSource()
_time = secondsBetweenFetches;
}

/// <summary>
/// A Unity event function that is called every frame, if this object is enabled.
/// </summary>
private void Update()
{
_time += Time.deltaTime;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ protected void JsonFetchSuccess(string jsonText, object requestRef)
}
}

/// <summary>
/// A Unity event function that is called every frame, if this object is enabled.
/// </summary>
private void Update()
{
_time += Time.deltaTime;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,18 @@ public string[] GetDataSourceTypes()
return new string[] { dataSourceType };
}

/// <summary>
/// A Unity event function that is called when the script component has been enabled.
/// </summary>
private void OnEnable()
{
GetDataSource(dataSourceType);
InitializeData();
}

/// <summary>
/// A Unity event function that is called every frame, if this object is enabled.
/// </summary>
private void Update()
{
if (_fluxCollectionSize > 0)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ protected override void InitializeDataSource()
_nextOneSecondTarget = 0;
}

/// <summary>
/// A Unity event function that is called every frame, if this object is enabled.
/// </summary>
private void Update()
{
Sprite[] statusSprites = { statusSpriteOpen, statusSpritePending, statusSpriteCancelled, statusSpriteInProgress, statusSpriteCompleted };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,17 @@ public void NextTheme()
ChangeTheme((currentTheme + 1) % availableThemes.Length);
}

/// <summary>
/// A Unity Editor-only event function that is called when the script is loaded or a value changes in the Unity Inspector.
/// </summary>
private void OnValidate()
{
ChangeTheme(currentTheme);
}

/// <summary>
/// A Unity event function that is called every frame, if this object is enabled.
/// </summary>
private void Update()
{
if (_lastTheme != currentTheme)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1428,15 +1428,15 @@ MonoBehaviour:
<OnDisabled>k__BackingField:
m_PersistentCalls:
m_Calls: []
smoothSelectedness: 1
smoothSelectionProgress: 1
distanceSpaceMode: 1
startPushPlane: -8.392723
endPushPlane: -0.67
returnSpeed: 0.25
enforceFrontPush: 1
rejectXYRolloff: 1
rolloffXYDepth: 3
rejectZRolloff: 0
rejectXYRollOff: 1
rollOffXYDepth: 3
rejectZRollOff: 0
extendSpeed: 0.5
--- !u!114 &9062819528647497188
MonoBehaviour:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -547,8 +547,8 @@ MonoBehaviour:
m_PersistentCalls:
m_Calls: []
m_text: StatefulPressableButton defines the pressability of an object, by overriding
the virtual Selectedness() function. The PressableButtonVisuals interprets this
Selectedness, along with the other conditions + flags exposed by MRTKBaseInteractable
the virtual GetSelectionProgress() function. The PressableButtonVisuals interprets this
GetSelectionProgress(), along with the other conditions + flags exposed by MRTKBaseInteractable
and StatefulInteractable, to drive the complex visual feedback you see here.
m_isRightToLeft: 0
m_fontAsset: {fileID: 11400000, guid: fea6b26abeefbc547b6aca1dbda0a34d, type: 2}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2802,8 +2802,8 @@ MonoBehaviour:


PressableButtons
use StatefulInteractable''s Selectedness to model the compressability of a 3D
pressable surface. These interactables drive Selectedness through a combination
use StatefulInteractable''s selection progress to model the compressability of a 3D
pressable surface. These interactables drive selection progress through a combination
of any number of interactors.'
m_isRightToLeft: 0
m_fontAsset: {fileID: 11400000, guid: 533bdd8d5c92b52448ee2ecf7bd828a4, type: 2}
Expand Down Expand Up @@ -6496,7 +6496,7 @@ MonoBehaviour:


<size=8>Dynamic
visual feedback based on the amount of pinch gesture (Selectedness) using StateVisualizer''s
visual feedback based on the amount of pinch gesture (selection progress) using StateVisualizer''s
''Playback Time Matches Value''. Hover highlight is activated by MeshOutline
script.

Expand Down Expand Up @@ -11973,55 +11973,55 @@ PrefabInstance:
value: 0
objectReference: {fileID: 0}
- target: {fileID: 9075688916865880869, guid: 7148f9ce86f62ab4b8d89dc6cfa369a0, type: 3}
propertyPath: OnValueUpdated.m_PersistentCalls.m_Calls.Array.size
propertyPath: onValueUpdated.m_PersistentCalls.m_Calls.Array.size
value: 1
objectReference: {fileID: 0}
- target: {fileID: 9075688916865880869, guid: 7148f9ce86f62ab4b8d89dc6cfa369a0, type: 3}
propertyPath: OnValueUpdated.m_PersistentCalls.m_Calls.Array.data[0].m_Mode
propertyPath: onValueUpdated.m_PersistentCalls.m_Calls.Array.data[0].m_Mode
value: 0
objectReference: {fileID: 0}
- target: {fileID: 9075688916865880869, guid: 7148f9ce86f62ab4b8d89dc6cfa369a0, type: 3}
propertyPath: OnValueUpdated.m_PersistentCalls.m_Calls.Array.data[1].m_Mode
propertyPath: onValueUpdated.m_PersistentCalls.m_Calls.Array.data[1].m_Mode
value: 1
objectReference: {fileID: 0}
- target: {fileID: 9075688916865880869, guid: 7148f9ce86f62ab4b8d89dc6cfa369a0, type: 3}
propertyPath: OnValueUpdated.m_PersistentCalls.m_Calls.Array.data[0].m_Target
propertyPath: onValueUpdated.m_PersistentCalls.m_Calls.Array.data[0].m_Target
value:
objectReference: {fileID: 2123527399}
- target: {fileID: 9075688916865880869, guid: 7148f9ce86f62ab4b8d89dc6cfa369a0, type: 3}
propertyPath: OnValueUpdated.m_PersistentCalls.m_Calls.Array.data[1].m_Target
propertyPath: onValueUpdated.m_PersistentCalls.m_Calls.Array.data[1].m_Target
value:
objectReference: {fileID: 0}
- target: {fileID: 9075688916865880869, guid: 7148f9ce86f62ab4b8d89dc6cfa369a0, type: 3}
propertyPath: OnValueUpdated.m_PersistentCalls.m_Calls.Array.data[0].m_CallState
propertyPath: onValueUpdated.m_PersistentCalls.m_Calls.Array.data[0].m_CallState
value: 2
objectReference: {fileID: 0}
- target: {fileID: 9075688916865880869, guid: 7148f9ce86f62ab4b8d89dc6cfa369a0, type: 3}
propertyPath: OnValueUpdated.m_PersistentCalls.m_Calls.Array.data[1].m_CallState
propertyPath: onValueUpdated.m_PersistentCalls.m_Calls.Array.data[1].m_CallState
value: 2
objectReference: {fileID: 0}
- target: {fileID: 9075688916865880869, guid: 7148f9ce86f62ab4b8d89dc6cfa369a0, type: 3}
propertyPath: OnValueUpdated.m_PersistentCalls.m_Calls.Array.data[0].m_MethodName
propertyPath: onValueUpdated.m_PersistentCalls.m_Calls.Array.data[0].m_MethodName
value: SpinObjectWithSlider
objectReference: {fileID: 0}
- target: {fileID: 9075688916865880869, guid: 7148f9ce86f62ab4b8d89dc6cfa369a0, type: 3}
propertyPath: OnValueUpdated.m_PersistentCalls.m_Calls.Array.data[1].m_MethodName
propertyPath: onValueUpdated.m_PersistentCalls.m_Calls.Array.data[1].m_MethodName
value:
objectReference: {fileID: 0}
- target: {fileID: 9075688916865880869, guid: 7148f9ce86f62ab4b8d89dc6cfa369a0, type: 3}
propertyPath: OnValueUpdated.m_PersistentCalls.m_Calls.Array.data[0].m_TargetAssemblyTypeName
propertyPath: onValueUpdated.m_PersistentCalls.m_Calls.Array.data[0].m_TargetAssemblyTypeName
value: Microsoft.MixedReality.Toolkit.Examples.Demos.ObjectSpinner, Assembly-CSharp
objectReference: {fileID: 0}
- target: {fileID: 9075688916865880869, guid: 7148f9ce86f62ab4b8d89dc6cfa369a0, type: 3}
propertyPath: OnValueUpdated.m_PersistentCalls.m_Calls.Array.data[1].m_TargetAssemblyTypeName
propertyPath: onValueUpdated.m_PersistentCalls.m_Calls.Array.data[1].m_TargetAssemblyTypeName
value: Microsoft.MixedReality.Toolkit.Examples.Demos.SliderGemSpinner, Assembly-CSharp
objectReference: {fileID: 0}
- target: {fileID: 9075688916865880869, guid: 7148f9ce86f62ab4b8d89dc6cfa369a0, type: 3}
propertyPath: OnValueUpdated.m_PersistentCalls.m_Calls.Array.data[0].m_Arguments.m_ObjectArgumentAssemblyTypeName
propertyPath: onValueUpdated.m_PersistentCalls.m_Calls.Array.data[0].m_Arguments.m_ObjectArgumentAssemblyTypeName
value: UnityEngine.Object, UnityEngine
objectReference: {fileID: 0}
- target: {fileID: 9075688916865880869, guid: 7148f9ce86f62ab4b8d89dc6cfa369a0, type: 3}
propertyPath: OnValueUpdated.m_PersistentCalls.m_Calls.Array.data[1].m_Arguments.m_ObjectArgumentAssemblyTypeName
propertyPath: onValueUpdated.m_PersistentCalls.m_Calls.Array.data[1].m_Arguments.m_ObjectArgumentAssemblyTypeName
value:
objectReference: {fileID: 0}
m_RemovedComponents: []
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5650,7 +5650,7 @@ PrefabInstance:
selection.


The virtual Selectedness method can be overridden to
The virtual GetSelectionProgress() method can be overridden to
support more kinds of variable selection, like volumetric press. By default,
StatefulInteractables will receive the variable selection amount from all
participating IVariableSelectInteractors.'
Expand Down Expand Up @@ -20980,7 +20980,7 @@ PrefabInstance:
- target: {fileID: 2446705927233332293, guid: e8c3ea3c1046f8b4bbd682c2b7a0e4fe, type: 3}
propertyPath: m_text
value: 'PressableButton defines the pressability of an object by overriding
the virtual Selectedness() function.
the virtual GetSelectionProgress() function.


Notably, PressableButton,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5425,7 +5425,7 @@ MonoBehaviour:
maxViewHorizontalDegrees: 30
maxViewVerticalDegrees: 20
reorientWhenOutsideParameters: 1
orientToControllerDeadzoneDegrees: 60
orientToControllerDeadZoneDegrees: 60
ignoreAngleClamp: 0
ignoreDistanceClamp: 0
ignoreReferencePitchAndRoll: 0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ public class AdjustLabelPosition : MonoBehaviour
[Tooltip("The object whose dimensions controls the placement of this object.")]
private Transform control;

private void Awake()
/// <summary>
/// A Unity event function that is called when an enabled script instance is being loaded.
/// </summary>
protected virtual void Awake()
{
// Calculate the new position of the label based on the current size of the backplate
float childOffset = ((control.lossyScale.y) / 2f * -1);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ public class BandPassFilterSelection : MonoBehaviour

private AudioBandPassEffect effect = null;

/// <summary>
/// A Unity event function that is called on the frame when a script is enabled just before any of the update methods are called the first time.
/// </summary>
private void Start()
{
effect = audioEmitter.EnsureComponent<AudioBandPassEffect>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ public class ColorChanger : MonoBehaviour

private int currentMaterialSelection;

/// <summary>
/// A Unity event function that is called on the frame when a script is enabled just before any of the update methods are called the first time.
/// </summary>
private void Start()
{
if (meshRenderer == null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ public class DialogExample : MonoBehaviour
{
public DialogPool DialogPool;

public void Awake()
/// <summary>
/// A Unity event function that is called when an enabled script instance is being loaded.
/// </summary>
protected virtual void Awake()
{
if (DialogPool == null)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ public TMP_Text Text
set => text = value;
}

/// <summary>
/// A Unity event function that is called when the script component has been enabled.
/// </summary>
private void OnEnable()
{
if (checker == null)
Expand Down
10 changes: 7 additions & 3 deletions UnityProjects/MRTKDevTemplate/Assets/Scripts/GridSqueezer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ public GridLayoutGroup GridLayoutGroup
}

[SerializeField]
[Tooltip("The RectTransform to fit the collider onto.")]
[Tooltip("The AttachedRectTransform to fit the collider onto.")]
AMollis marked this conversation as resolved.
Show resolved Hide resolved
private RectTransform rectTransform;

/// <summary>
/// The RectTransform to fit the collider onto.
/// The AttachedRectTransform to fit the collider onto.
/// </summary>
public RectTransform RectTransform
{
Expand All @@ -68,7 +68,11 @@ public RectTransform RectTransform
}
set => rectTransform = value;
}
void Update()

/// <summary>
/// A Unity event function that is called every frame, if this object is enabled.
/// </summary>
private void Update()
{
if (!(Application.isPlaying && !DynamicFitting) && GridLayoutGroup != null && RectTransform != null && RectTransform.hasChanged)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@

namespace Microsoft.MixedReality.Toolkit.Examples.Demos
{
/// <summary>
/// A helper component for creating a <see cref="DialogPool"/> and showing <see cref="IDialog"/> objects.
/// </summary>
public class InspectorDrivenDialog : MonoBehaviour
{
// A handy struct for keeping button actions and their labels together.
Expand Down Expand Up @@ -39,6 +42,9 @@ internal struct Option
[SerializeField]
private Option neutral;

/// <summary>
/// A Unity event function that is called when the script component has been enabled.
/// </summary>
protected virtual void OnEnable()
{
if (DialogPool == null)
Expand All @@ -47,6 +53,9 @@ protected virtual void OnEnable()
}
}

/// <summary>
/// Show a <see cref="IDialog"/> object using the currently set text and button options.
/// </summary>
public void Show()
{
// Any fields left blank in the inspector are considered
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,10 @@ void OnTriggerStay(Collider c)
}
}

void FixedUpdate()
/// <summary>
/// A Unity event function that is called at an framerate independent frequency, and is only called if this object is enabled.
/// </summary>
private void FixedUpdate()
{
hoveredTargets.Clear();
}
Expand Down
Loading