Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FocusedObject property #10

Merged
merged 1 commit into from
Apr 18, 2016

Conversation

dotMorten
Copy link

Adds a property to GestureManager to address Issue #9

@msftclas
Copy link

Hi @dotMorten, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@UWarbs
Copy link

UWarbs commented Apr 15, 2016

@dotMorten
I think the focused object change code look like this instead. (switch the 'OnGazeLeave' and 'OnGazeEnter')

            if(oldHitObject != currentHitObject) //The currently hit object has changed
            {
                 if (oldHitObject != null)
                    oldHitObject.SendMessage("OnGazeLeave");
                 if (currentHitObject != null)
                    currentHitObject.SendMessage("OnGazeEnter");
            }

@dotMorten
Copy link
Author

dotMorten commented Apr 15, 2016

@UWarbs I think you commented in the wrong PR(but I fixed it - thanks - dumb last minute clean up!). Btw. in the PR you can add comments directly to a specific line of code by clicking the + next to the line. Makes it easier to review and follow up.

@NeerajW NeerajW merged commit 7748e8a into microsoft:master Apr 18, 2016
@dotMorten dotMorten deleted the GestureManager/FocusedObject branch April 18, 2016 23:29
NeerajW pushed a commit that referenced this pull request Oct 21, 2016
Merge pull request #258 from HodgsonSDAS/Sharing_SDK_Update
keveleigh pushed a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Jun 5, 2018
June18 dev --> SolverExampleUpdates
StephenHodgson pushed a commit that referenced this pull request Jun 6, 2018
cre8ivepark referenced this pull request in cre8ivepark/MixedRealityToolkit-Unity May 24, 2019
keveleigh pushed a commit that referenced this pull request Jun 6, 2019
drusk-unity pushed a commit to drusk-unity/MixedRealityToolkit-Unity that referenced this pull request Jun 23, 2023
…smSpatialAwarenessExample-to-MRTK3-#11499

Add SurfaceMagnetismSpatialAwarenessExample
drusk-unity pushed a commit to drusk-unity/MixedRealityToolkit-Unity that referenced this pull request Jun 26, 2023
…smSpatialAwarenessExample-to-MRTK3-#11499

Add SurfaceMagnetismSpatialAwarenessExample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants