Reading Mode Doesn't work with URP

[pajama]

Reading Mode Doesn't work with URP. Likely because OnPreCall is never called. RenderPipelineManager events needs to be implemented.

Also RenderViewportScale doesn't work with URP, but I'm guessing this is an underlying Unity OpenXR issue?

To reproduce

Switch to URP. Try the ReadingModeDemo.

Expected behavior

Reading mode demo should perform as expected.

• Unity Version 2020.3.20f1
• MRTK Version 2.7.2
• HoloLens 2
  -OpenXR

[polar-kev]

Thanks for filing @pajama

[polar-kev]

FYI @KevinKennedy.

[Zee2]

@Cameron-Micka , is this something we're thinking about for MRGT?

[Cameron-Micka]

Oh, what is the "reading mode" demo?

[keveleigh]

Info on reading mode: https://docs.microsoft.com/hololens/hololens2-display#what-improvements-are-coming-that-will-improve-hololens-2-image-quality

Some MRTK2 background: #8344, #8651, #8808

[Cameron-Micka]

Thanks @keveleigh, I had no idea this was a feature. This is not something we've considered for MRGT but could be something we think about. We already have defines in place to conditionally compile URP specific logic so should be too hard to support both pipelines.

I'm open to tracking this issue here: https://github.com/microsoft/MixedReality-GraphicsTools-Unity/issues or if someone has time to make the change, I'm happy to review the PR. 😊

[Zee2]

@Cameron-Micka, created an issue for ya :)

[Cameron-Micka]

Thanks!

[Zee2]

Closing as duplicate of the new MRGT issue (microsoft/MixedReality-GraphicsTools-Unity#97)