-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed Billboards alignment across all axes.
- Loading branch information
Showing
1 changed file
with
11 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d8fd92
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old way used to only affect the x/y axes. Setting Free meant setting both X and Y. The new code now sets the z as well when you set free.
There should be an option for just X and Y (example: Tag-a-longs).
4d8fd92
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little unclear on what you're trying to achieve, but I think for most Tag-a-long style things this should work. For reference, the new FPS display prefab is an example of a tag along that uses this Billboard class as is and pivots around the Y-axis (Up in Unity).
4d8fd92
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try to clarify: previously the billboard for a tagalong in Free would turn so that it was facing the camera on both orientations. So, if you were looking straight down at it would face the user as it was oriented with the floor, similar to the bloom menu. It still does this but now it also rotates on the Z axis so that it's essentially rotated with the user's head rather than staying in line with the rest of the world. While this can keep the tagalong or whatever in the holographic frame, it's also a little disorienting and doesn't match the way the UI works in the shell. So another option that would allow Free rotation but with a locked Z axis would be desirable (and would match the previous functionality).
4d8fd92
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think that makes sense. I'll make an issue!
4d8fd92
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#208 for reference, let's move any further conversation there.