Fix FollowMeToggle's auto-follow breaking if the component is disabled (

#10620) * Fix FollowMeToggle's auto-follow breaking if the component is ever disabled `FollowMeToggle` has an `AutoFollowAtDistance` feature which breaks if the `FollowMeToggle` component is ever disabled and re-enabled. This is because the `AutoFollowAtDistance` property setter checks if the `autoFollowDistanceCheck` coroutine is null before starting the coroutine. If the component is disabled, the coroutine will _stop_ but not become null. When the component is re-enabled, the coroutine does not start again because the previous instance is non-null, even though it is no longer running. This is fixed by simply setting `autoFollowDistanceCheck` to null in `OnDisable()`. * FollowMeToggle: formatting tweak Per keveleigh Co-authored-by: Kurtis <[email protected]> Co-authored-by: Kurtis <[email protected]>
microsoft · May 31, 2022 · 2cb1d75 · 2cb1d75
1 parent eb3125f
commit 2cb1d75
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/Assets/MRTK/SDK/Features/UX/Scripts/Slate/FollowMeToggle.cs b/Assets/MRTK/SDK/Features/UX/Scripts/Slate/FollowMeToggle.cs
@@ -183,6 +183,11 @@ private void OnEnable()
             // Begin the follow coroutine when enabled.
             AutoFollowAtDistance = autoFollowAtDistance;
         }
+
+        private void OnDisable()
+        {
+            autoFollowDistanceCheck = null;
+        }
 
         #endregion MonoBehaviour Implementation