M365DSCReport: Add support for creating a report in CSV-format #5501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $newRow = $modelRow.Clone() | ||
| if ($row -gt 0) | ||
| { | ||
| write-verbose "add separator-line in CSV-file between resources" |
There was a problem hiding this comment.
Suggested change
| write-verbose "add separator-line in CSV-file between resources" | |
| Write-Verbose -Message "Add separator-line in CSV-file between resources" |
| $newRow.Value = $value | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Please remove this empty line.
Comment on lines
718
to
726
| begin | ||
| { | ||
| if ($PSBoundParameters.ContainsKey('Delimiter')) | ||
| { | ||
| $Delimiter = $PSBoundParameters.Delimiter | ||
| } | ||
| } | ||
| process # required with DynamicParam | ||
| { |
There was a problem hiding this comment.
Indentation is not correct, leading to a curly bracket on the same line as another end block on line 778.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR adds support for -Type CSV in New-M365DSCReportFromConfiguration and adds dynamic parameter -Delimiter when -Type CSV is used
This Pull Request (PR) fixes the following issues
I'm having issues creating an Excel-report of a configuration. On my local PC where I'm not a local admin the generation of the report fails with a CIM-error and on my admin-server I don't have Excel available. The obvious solution (for me) is to create the report in CSV-format and import it into Excel later.
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).