Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Intune role assignment and cloud login variable #5473

Merged

Conversation

FabienTschanz
Copy link
Contributor

Pull Request (PR) description

This PR fixes three things:

  • First, it improves the overall output of IntuneRoleAssignment and some copy-pasted variables
  • Secondly, it fixes the incorrect variable $Global:MSCloudLoginAssistant to $Global:MSCloudLoginConnectionProfile
  • Thirdly, it adds the AccessTokens property to the output of the Get method

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

@ricmestre
Copy link
Contributor

Apart from the wrong casing it looks good to me, fortunately (or rather unfortunate) the reason why the resources didn't fail because of the MSCloudLoginAssistant variable is due to Graph not complaining about the URIs used anywhere as long as they start with the API name (beta vs v1.0) which they did because the MSCloudLoginAssistant variable was always null.

@FabienTschanz FabienTschanz force-pushed the fix/cloud-login-and-role-assignment branch from 3354573 to 5e7d0c7 Compare November 27, 2024 12:05
@FabienTschanz
Copy link
Contributor Author

@ricmestre True dat, I only stumbled upon it because the IntuneRoleAssignment had a direct relation to such a URL which was failing. Thanks for the review, I updated the casing.

@NikCharlebois NikCharlebois merged commit adabd5f into microsoft:Dev Nov 27, 2024
2 checks passed
@FabienTschanz FabienTschanz deleted the fix/cloud-login-and-role-assignment branch November 27, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants