Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3787 #5400

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Fixes #3787 #5400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce85749
Fixes #3787
NikCharlebois Nov 13, 2024
4f5569f
Update Microsoft365DSC.AADRoleEligibilityScheduleRequest.Tests.ps1
NikCharlebois Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
* Fixes a bug where 3P apps could not be assigned by DisplayName for both
IncludeApplications and ExcludeApplications
FIXES [#5390](https://github.com/microsoft/Microsoft365DSC/issues/5390)
* AADRoleEligibilityScheduleRequest
* FIXES [#3787](https://github.com/microsoft/Microsoft365DSC/issues/3787)
* FIXES [#5089](https://github.com/microsoft/Microsoft365DSC/issues/5089)
* EXOATPBuiltInProtectionRule, EXOEOPProtectionRule
* Fixed issue where empty arrays were being compared incorrectly to null
strings
Expand Down
2 changes: 1 addition & 1 deletion ...ources/MSFT_AADRoleEligibilityScheduleRequest/MSFT_AADRoleEligibilityScheduleRequest.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@
$schedule = $instance
}
}
[Array]$request = Get-MgBetaRoleManagementDirectoryRoleEligibilityScheduleRequest -Filter "PrincipalId eq '$PrincipalId' and RoleDefinitionId eq '$($schedule.RoleDefinitionId)'" | Sort-Object -Property CompletedDateTime -Descending
[Array]$request = Get-MgBetaRoleManagementDirectoryRoleEligibilityScheduleRequest -Filter "PrincipalId eq '$PrincipalId'" | Where-Object -FilterScript {$_.RoleDefinitionId -eq $schedule.RoleDefinitionId} | Sort-Object -Property CompletedDateTime -Descending
`
if ($request.Length -gt 1)
{
Expand Down
1 change: 1 addition & 0 deletions Tests/Unit/Microsoft365DSC/Microsoft365DSC.AADRoleEligibilityScheduleRequest.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ Describe -Name $Global:DscHelper.DescribeHeader -Fixture {
Mock -CommandName Get-MgBetaRoleManagementDirectoryRoleEligibilitySchedule -MockWith {
return @{
Id = '12345-12345-12345-12345-12345'
RoleDefinitionId = "12345"
}
}

Expand Down
Loading