Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to M365DSCReport.psm1 due to typo in script #4983

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

Harleycox
Copy link
Contributor

Correcting a typo for the name of the Security & compliance.png file the M365DSCReport.psm1 script when it tries to pull it. Essentially it was missing an 'i' in compliance which meant it errored out every time it tries to call the .png file.

Correcting a typo for the name of the Security & compliance.png file the M365DSCReport.psm1 script when it tries to pull it. Essentially it was missing an 'i' in compliance which meant it errored out every time it tries to call the .png file
@ykuijs
Copy link
Member

ykuijs commented Aug 23, 2024

@Harleycox, great spot. One ask: Could you also add an entry in the changelog for this change. Please add this to the MISC header.

@ykuijs
Copy link
Member

ykuijs commented Aug 26, 2024

I have seen the 2nd PR you have submitted. Please update this PR with that change. Simply make the change, commit to the same branch and push the new commit to GitHub. That will automatically add the commit to this PR.

I will close the 2nd PR.

@Harleycox
Copy link
Contributor Author

I have seen the 2nd PR you have submitted. Please update this PR with that change. Simply make the change, commit to the same branch and push the new commit to GitHub. That will automatically add the commit to this PR.

I will close the 2nd PR.

Hi Ykuijs, apologies! Frist time committing, this should hopefully have now been done in the correct way. Please let me know if not.

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs
Copy link
Member

ykuijs commented Aug 27, 2024

Thanks for the update @Harleycox! Please check-out the license agreement message earlier in the message thread and acknowledge if you are ok with it. After that we can merge the PR.

@Harleycox
Copy link
Contributor Author

Read and confirmed

@microsoft-github-policy-service agree

@ssoabx
Copy link
Contributor

ssoabx commented Aug 27, 2024

Oh, I submitted a duplicate, was searching for SecurityAndCompliance and saw nothing. Thanks for fixing :)

@ykuijs
Copy link
Member

ykuijs commented Aug 28, 2024

No problem. Your contribution is very much appreciated. Better submit a duplicate than not fixing the issue at all 😉

@ykuijs ykuijs merged commit 70cf097 into microsoft:Dev Aug 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants