Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not throw if configuration is empty during report generation #4867

Merged

Conversation

FabienTschanz
Copy link
Contributor

@FabienTschanz FabienTschanz commented Jul 11, 2024

Pull Request (PR) description

This pull request addresses a reported issue when the configuration to create a report from was empty. Currently, it throws an exception, but that isn't the best solution, especially if multiple reports are being generated, because an exception stops the entire processing of the reports.

The proposed change is to output a warning, stating that the configuration was empty and no report was created. Another way that was suggested is to create an empty report stating something like No configuration found, but that requires additional handling in the create functions for the specific report type.

For visibility:
@andikrueger

This Pull Request (PR) fixes the following issues

@FabienTschanz
Copy link
Contributor Author

Note: The Unit tests are failing due to changes in the Dev branch. I will update the PR as soon as that works again.

@NikCharlebois NikCharlebois merged commit 06f729c into microsoft:Dev Jul 16, 2024
2 checks passed
@FabienTschanz FabienTschanz deleted the fix/empty-report-configuration branch July 16, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants