Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings instance array return value #4845

Merged

Conversation

FabienTschanz
Copy link
Contributor

Pull Request (PR) description

This pull request fixes an issue where the supposed return value of an array with items was mangled to the single element by PowerShell in case there was only one element in the array.

This Pull Request (PR) fixes the following issues

@ricmestre
Copy link
Contributor

Just tested it now, and yes it solves the issue but it also looks good. The thing is that you always need to battle test it, unfortunately at least as Graph API goes you need to test several times because the backend sometimes goes against you, as you've seen on your side it worked a few times and then you the same issue as I encountered. See #4771, not Graph related but this one was working for the longest time and now doesn't and it's not even about the code in M365DSC

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs ykuijs merged commit f7b408b into microsoft:Dev Jul 10, 2024
2 checks passed
@FabienTschanz FabienTschanz deleted the fix/intune-settings-catalog-settings branch July 10, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IntuneSettingCatalogASRRulesPolicyWindows10: Not working
3 participants