-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AADUser advanced query filter support #4430
Conversation
Hello @ifinch I noticed some tenant specific info in your PR: Microsoft365DSC/Modules/Microsoft365DSC/DSCResources/MSFT_AADUser/MSFT_AADUser.psm1 Lines 981 to 982 in 310ecc2
Also, have you considered the addition of a new switch parameters AdvancedQuery to set the CountVariable and ConsistencyLevel instead of adding the extra logic? In all available Graph SDK's the user has the responsibility to specify if the query is "advanced" (or not). Keeping up with future changes in the graph for these query types and properties seems a lot of extra work. Similar logic will have to be implemented on other DSC resource (AADGroups, ...) as well. |
Hey @bartvermeersch , Those ones are precented in the advanced query doc extension_4750531c75d84e8698ecd21bbd5da9f5_fruitPreference However, there is difference how MgUser vs MsBetaUsers and as MgUser used, some of the extensions should be cleaned up including those you pointed out. I have not considered AdvancedQuery switch this far. |
Hi @NikCharlebois , anything extra needed to follow up on this removing from On-Hold state? |
Modules/Microsoft365DSC/DSCResources/MSFT_AADUser/MSFT_AADUser.psm1
Outdated
Show resolved
Hide resolved
My only concern here is that we will need to manage a hardcoded list of possible filters. |
check if $Filter is null implemented
completely agreed, but not that many options we have now to make differently AFAIK |
Hi @NikCharlebois any ETA on this to be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed printing "Filter is null" on export with a Write-Host
Code styling
Pull Request (PR) description
advanced query filter support
This Pull Request (PR) fixes the following issues
-Fixes #2430