-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add group display name to Intune Assignment (Batch 1) #4323
PR: Add group display name to Intune Assignment (Batch 1) #4323
Conversation
…/William-Francillette/Microsoft365DSC-1 into IntuneAssignmentGroupDisplayName
…in IntuneAppConfigurationPolicy
@NikCharlebois @ykuijs - not sure why but the test fails due to function not found but added to M365DSCUtil module so until it gets merged it will fail |
...365DSC/DSCResources/MSFT_IntuneAppConfigurationPolicy/MSFT_IntuneAppConfigurationPolicy.psm1
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments/questions.
Also, not sure if I like the change of returning the nullresult to throwing an exception. Continuing the discussion in the other issue first.
...5DSC/DSCResources/MSFT_IntuneAccountProtectionPolicy/MSFT_IntuneAccountProtectionPolicy.psm1
Show resolved
Hide resolved
Now understand what you mean with the comment about the alternative solution being implemented in the issue. Didn't find it right away in this PR, but overlooked the comment that you only implemented it on one resource 😉 Will add a comment to the issue. |
…pdated M365DSCUtil exported functions
…/William-Francillette/Microsoft365DSC-1 into IntuneAssignmentGroupDisplayName
Quick comment: Please also correct the changelog. Currently there are two Unreleased sections. |
…lDevices/allUsers groups
Pull Request (PR) description
This Pull Request (PR) fixes the following issues