Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add group display name to Intune Assignment (Batch 1) #4323

Conversation

William-Francillette
Copy link
Contributor

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

  • IntuneAccountProtectionLocalAdministratorPasswordSolutionPolicy
    • Added support for assignment GroupDisplayName
  • IntuneAccountProtectionLocalUserGroupMembershipPolicy
    • Added support for assignment GroupDisplayName
  • IntuneAccountProtectionPolicy
    • Added support for assignment GroupDisplayName
  • IntuneAntivirusPolicyWindows10SettingCatalog
    • Added support for assignment GroupDisplayName
  • IntuneAppConfigurationPolicy
    • Added support for assignment GroupDisplayName
  • IntuneApplicationControlPolicyWindows10
    • Added support for assignment GroupDisplayName
  • IntuneASRRulesPolicyWindows10
    • Added support for assignment GroupDisplayName
  • IntuneDeviceCompliancePolicyAndroid
    • Added support for assignment GroupDisplayName
  • IntuneDeviceCompliancePolicyAndroidDeviceOwner
    • Added support for assignment GroupDisplayName
  • IntuneDeviceCompliancePolicyAndroidWorkProfile
    • Added support for assignment GroupDisplayName
  • IntuneDeviceCompliancePolicyiOs
    • Added support for assignment GroupDisplayName
  • IntuneDeviceCompliancePolicyMacOS
    • Added support for assignment GroupDisplayName
  • IntuneDeviceCompliancePolicyWindows10
    • Added support for assignment GroupDisplayName

@William-Francillette
Copy link
Contributor Author

@NikCharlebois @ykuijs - not sure why but the test fails due to function not found but added to M365DSCUtil module so until it gets merged it will fail

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments/questions.

Also, not sure if I like the change of returning the nullresult to throwing an exception. Continuing the discussion in the other issue first.

@ykuijs
Copy link
Member

ykuijs commented Feb 26, 2024

Now understand what you mean with the comment about the alternative solution being implemented in the issue. Didn't find it right away in this PR, but overlooked the comment that you only implemented it on one resource 😉

Will add a comment to the issue.

@ykuijs
Copy link
Member

ykuijs commented Feb 26, 2024

Quick comment: Please also correct the changelog. Currently there are two Unreleased sections.

@William-Francillette
Copy link
Contributor Author

William-Francillette commented Feb 27, 2024

  • Added support for groupDisplayName for an additional 7 resources

    • IntuneDeviceConfigurationAdministrativeTemplatePolicyWindows10
    • IntuneDeviceConfigurationCustomPolicyWindows10
    • IntuneDeviceConfigurationDefenderForEndpointOnboardingPolicyWindows10
    • IntuneDeviceConfigurationDeliveryOptimizationPolicyWindows10
    • IntuneDeviceConfigurationDomainJoinPolicyWindows10
    • IntuneDeviceConfigurationEmailProfilePolicyWindows10
    • IntuneDeviceConfigurationEndpointProtectionPolicyWindows10
  • Also added groupDisplayName for the All Users and All Devices assignments (M365DSCDRGUtil: ConvertFrom-IntunePolicyAssignment)
    image

@NikCharlebois NikCharlebois merged commit 657c303 into microsoft:Dev Mar 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants