-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added Parameter ConditionalAccessPolicy to Resource SPOAccessControlSettings #4290
Conversation
@microsoft-github-policy-service agree |
...ft365DSC/DSCResources/MSFT_SPOAccessControlSettings/MSFT_SPOAccessControlSettings.schema.mof
Outdated
Show resolved
Hide resolved
Hello, I'm unsure If I did something wrong with my second commit to correct the issues outlined by @NikCharlebois . |
Could you please add a changelog entry within the unrelease section and outline this addition? Thanks! |
I have added the parameter to the unreleased section. I hope I did no mistake. Since I do not know how to resolve the Conflict furthermore. |
I just resolved the conflict. Thanks for looking into it and your contribution! |
Thank you very much for correcting the conflict. I was unable to do it correctly. |
Hello @NikCharlebois , is there more to deliver, or can this be merged now? |
hello @andikrueger , sorry to bother you again. since there was created a new release, the addition from this MR to the unreleased section does have a conflict again. I kindly ask you to resolve this conflict, since I think my changes would worsen the current situation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment.
...icrosoft365DSC/DSCResources/MSFT_SPOAccessControlSettings/MSFT_SPOAccessControlSettings.psm1
Outdated
Show resolved
Hide resolved
Hi @andikrueger please review my recent changes. :) |
Hi @andikrueger , I tried to fix the condlict with the last release by myself. but I still ended up with a conflict. I used this command to update my branch with the incoming commits from dev: |
hello @andikrueger and @NikCharlebois, is there something that hinders this addition to the dev tree? |
Hi @NikCharlebois since your approval is required too, can you approve the merge request as well? thank you very much |
hi @andikrueger, i allowing myself to kindly ask you, if there is something to provide, so nik could approve this change? |
Pull Request (PR) description
Added Parameter ConditionalAccessPolicy to Resource SPOAccessControlSettings. Based on the PNP Module documentation:
https://pnp.github.io/powershell/cmdlets/Set-PnPTenant.html#-conditionalaccesspolicy
This Pull Request (PR) fixes the following issues
None