Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added Parameter ConditionalAccessPolicy to Resource SPOAccessControlSettings #4290

Merged
merged 16 commits into from
Feb 26, 2024

Conversation

hosebei
Copy link
Contributor

@hosebei hosebei commented Feb 6, 2024

Pull Request (PR) description

Added Parameter ConditionalAccessPolicy to Resource SPOAccessControlSettings. Based on the PNP Module documentation:
https://pnp.github.io/powershell/cmdlets/Set-PnPTenant.html#-conditionalaccesspolicy

This Pull Request (PR) fixes the following issues

None

@hosebei
Copy link
Contributor Author

hosebei commented Feb 6, 2024

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

@hosebei hosebei requested a review from NikCharlebois February 6, 2024 18:25
@hosebei
Copy link
Contributor Author

hosebei commented Feb 9, 2024

Hello, I'm unsure If I did something wrong with my second commit to correct the issues outlined by @NikCharlebois .
Or if I just need to wait, until this get checked again. Thanks a lot for a response in advance.

@andikrueger
Copy link
Collaborator

Could you please add a changelog entry within the unrelease section and outline this addition? Thanks!

@hosebei
Copy link
Contributor Author

hosebei commented Feb 13, 2024

I have added the parameter to the unreleased section. I hope I did no mistake. Since I do not know how to resolve the Conflict furthermore.

@andikrueger
Copy link
Collaborator

I just resolved the conflict. Thanks for looking into it and your contribution!

@hosebei
Copy link
Contributor Author

hosebei commented Feb 13, 2024

Thank you very much for correcting the conflict. I was unable to do it correctly.

@hosebei
Copy link
Contributor Author

hosebei commented Feb 14, 2024

Hello @NikCharlebois , is there more to deliver, or can this be merged now?
Please tell me if I can adjust something to smoothen the process.

@hosebei
Copy link
Contributor Author

hosebei commented Feb 15, 2024

hello @andikrueger , sorry to bother you again. since there was created a new release, the addition from this MR to the unreleased section does have a conflict again. I kindly ask you to resolve this conflict, since I think my changes would worsen the current situation.
do you have an idea why this MR was not included in the last version?

Copy link
Collaborator

@andikrueger andikrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment.

@hosebei
Copy link
Contributor Author

hosebei commented Feb 15, 2024

Hi @andikrueger please review my recent changes. :)

@hosebei
Copy link
Contributor Author

hosebei commented Feb 17, 2024

Hi @andikrueger , I tried to fix the condlict with the last release by myself. but I still ended up with a conflict. I used this command to update my branch with the incoming commits from dev:
git checkout "pr/4290" && git merge dev
but the last released version of DSC in my code is now "1.24.214.1" instead of "1.24.214.2", when I check the changelog.md file in the dev branch.
I kindly ask you or @NikCharlebois to check if the parameter addition can be merged, and if you could resolve the conflict. thank you very much

@hosebei hosebei requested a review from andikrueger February 18, 2024 17:49
@hosebei
Copy link
Contributor Author

hosebei commented Feb 20, 2024

hello @andikrueger and @NikCharlebois, is there something that hinders this addition to the dev tree?

@hosebei
Copy link
Contributor Author

hosebei commented Feb 21, 2024

Hi @NikCharlebois since your approval is required too, can you approve the merge request as well? thank you very much

@hosebei
Copy link
Contributor Author

hosebei commented Feb 24, 2024

hi @andikrueger, i allowing myself to kindly ask you, if there is something to provide, so nik could approve this change?

@ykuijs ykuijs merged commit 740b3bc into microsoft:Dev Feb 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants