Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize Intune policy assignments #4247

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

FabienTschanz
Copy link
Contributor

Pull Request (PR) description

Adds a new parameter to the Update-DeviceConfigurationPolicyAssignment-Cmdlet to enable assignments for all Intune policies, despite different root key names.
Normally, the root key is assignments. In some cases, that name is changed to e.g. enrollmentConfigurationAssignments. The current implementation does not work with those different root key names. With the change, you can add the -RootIdentifier parameter with the root key name so that the POST and assign works for those resources as well.

This Pull Request (PR) fixes the following issues

None.

@ricmestre
Copy link
Contributor

ricmestre commented Feb 6, 2024

@NikCharlebois @andikrueger Hi, can this please be merged?

It'd still need a couple of fixes afterwards but the issue with assignments on IntuneDeviceEnrollmentPlatformRestriction that I reported on #4082 could be fixed with this in since the root identifier is hard coded right now to assignments but for this resource instead it needs to be enrollmentConfigurationAssignments as mentioned in https://learn.microsoft.com/en-us/graph/api/intune-shared-deviceenrollmentconfiguration-assign?view=graph-rest-beta

Edit: With that being said if this gets merged please don't close my issue #4082 since out of the box as I mentioned will still need some fixes.

@FabienTschanz
Copy link
Contributor Author

@NikCharlebois @andikrueger Can you have a look and merge it please? There is the pull request #4362 waiting that has this one as a requirement. And it's already open for a quite a long time too.

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs ykuijs merged commit 617df4e into microsoft:Dev Feb 26, 2024
2 checks passed
@FabienTschanz FabienTschanz deleted the improve-intune-assignments branch April 26, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants