Integration tests (Intune): Call Test-DSCConfiguration after deploying the config #4033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
After deploying the config then Test-DSCConfiguration to ensure that what was deployed to the tenant matches the config and while here add some error handling.
@NikCharlebois Thank you very much to start looking into this, much appreciated!!! It seems you've concatenated all available examples, but probably would be better to have separate configurations for each action (new, update, delete) just like it was done in https://github.com/microsoft/Microsoft365DSC/blob/365c23a1dbbbfad3c1a5c9cb372dec935a7487b4/Tests/Integration/Microsoft365DSC/MSFT_AADApplication.ps1. This one also tested different types of authentication which would be good to have, I've seen some resources that worked without issues with credentials and then failed with cert auth.
Anyway it's a good start, we don't have to do everything in just one go, this can be improved over time.
This Pull Request (PR) fixes the following issues