Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: IntuneDeviceEnrollmentStatusPageWindows10 - fixes: 3442 #3878

Merged
merged 3 commits into from
Nov 10, 2023
Merged

PR: IntuneDeviceEnrollmentStatusPageWindows10 - fixes: 3442 #3878

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f72ee31
fix typo: 3442
William-Francillette Nov 9, 2023
48296e0
removed Id as required
William-Francillette Nov 10, 2023
2b8d76c
prevent processing policies with duplicated names
William-Francillette Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...neDeviceEnrollmentStatusPageWindows10/MSFT_IntuneDeviceEnrollmentStatusPageWindows10.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,12 @@ function Get-TargetResource
Write-Verbose -Message "Could not find an Intune Device Enrollment Configuration for Windows10 with DisplayName {$DisplayName}"
return $nullResult
}

if($getValue -is [Array])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on @NikCharlebois recommendations #3344 , I've added a throw to prevent processing policies with duplicated names

{
Throw "The DisplayName {$DisplayName} returned multiple policies, make sure DisplayName is unique."
}

$Id = $getValue.Id
Write-Verbose -Message "An Intune Device Enrollment Configuration for Windows10 with Id {$Id} and DisplayName {$DisplayName} was found."

Expand Down