M365DSCReport: Also define property dataType, if present, as being primary key on CIM instances #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for suggesting this change! Could you please have a look at the conflict within the changelog? |
|
Done, if this gets in I'll update my other PR.. |
NikCharlebois
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Some CIM instances, most notably Assignments in almost all Intune resources have the property dataType but it's not being properly set as primary key in Get-M365DSCCimInstanceKey which might cause issues when comparing reports/blueprints.
This PR solves this by adding dataType as candidate for being primary key for CIM instances, just like odataType is already today.
This Pull Request (PR) fixes the following issues
None.