Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3759 #3762

Closed
wants to merge 8 commits into from
Closed

Issue #3759 #3762

wants to merge 8 commits into from

Conversation

desmay
Copy link
Collaborator

@desmay desmay commented Oct 6, 2023

Pull Request (PR) description

Check to validate if Team has an owner

This Pull Request (PR) fixes the following issues

Issue #3759

@desmay desmay requested a review from NikCharlebois as a code owner October 6, 2023 14:05
Copy link
Collaborator

@andikrueger andikrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor comments

@@ -4,6 +4,8 @@

* EXODistributionGroup
* Fixes the export of group membership to use Identity.
* TeamsTeam
* Check if Teams owners are null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the issue number to the changelog?

@@ -203,6 +203,10 @@ function Get-TargetResource
Ensure = 'Present'
}

if($null -ne $Owners){
$result.Add('Owner',$Owners[0].User.ToString())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aligns with the previous implementation. Why are we only grabbing the first user and not all owners of a team?

@pkernevez pkernevez mentioned this pull request Nov 7, 2023
@ykuijs
Copy link
Member

ykuijs commented Nov 10, 2023

This PR has been replaced by #3865. Closing this PR.

@ykuijs ykuijs closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TeamsTeam: w/o owners -> incomplete export ("Cannot index into a null array")
4 participants