Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.23.1004.1 #3751

Merged
merged 91 commits into from
Oct 4, 2023
Merged

Release 1.23.1004.1 #3751

merged 91 commits into from
Oct 4, 2023

Conversation

NikCharlebois
Copy link
Collaborator

No description provided.

menswearUK and others added 30 commits September 5, 2023 14:58
created using DRG, Specified cmdletNoun of MgbetaDeviceAppManagementPolicySet and API version of Beta
expand all properties when first getting object as they'll be required later (individual assignments command does not work).  some placeholder code for items too
Added items values to the output and amended processing to set up object. tested with export and test-m365dscconfiguration
code for adding a new resource now works, tested.  uses New-MgbetaDeviceAppManagementPolicySet to set all values
Updated non functional parts of this section of set-targetresource.  had to use graph calls for items and assignments as I can't get the cmdlets to work. tested
Also amended search for policy by name code as it was failing. tested
removed id from items object, it isn't used and it was causing issues when applying to a recreated policy set
guideddeploymenttags seems to be null but is an empty array when exported so corrected for this in returned object from get-targetresource
Intune endpoints were all hardcoded for graph.microsoft.com -- rendering the intune pull useless for GCC-H and DoD Cloud -- updated to pull the Graph Base URL from the existing  $Global:MSCloudLoginConnectionProfile.Intune.GraphBaseUrl variable
M365DSCDRGUtil changes to support multiple-clouds
Provided better working for update to M365DSCDRGUtil
Mismatched quotes in URI variable
inadvertent change.
tests file configured so it works and also uses dummy assignments and items objects
the status and errorcode values are not required - status is automatically set based on whether or not any groups are assigned to the policy set.  Errorcode is also not used in any part of the setup - checked graph calls via web interface and they're not setting these values either
added code to target single test file as per the issue
MSCloudLoginAssistant updated to Version 1.0.121
@NikCharlebois NikCharlebois added Release V1.23.1004.1 Version 1.23.1004.1 labels Oct 4, 2023
@NikCharlebois NikCharlebois merged commit 5d2c7bd into master Oct 4, 2023
16 of 18 checks passed
@NikCharlebois NikCharlebois temporarily deployed to PREVIEW October 4, 2023 14:09 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release V1.23.1004.1 Version 1.23.1004.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants