Add exact match parameter to avoid invalid multiple results #3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikCharlebois
requested changes
Oct 3, 2023
| @@ -365,7 +365,7 @@ function Export-TargetResource | |||
| $totalCount = $instances.Length | |||
| foreach ($item in $instances) | |||
| { | |||
| $Group = Find-CsGroup -SearchQuery $item.GroupId | |||
| $Group = Find-CsGroup -SearchQuery $item.GroupId -ExactMatchOnly $true | |||
There was a problem hiding this comment.
I am trying to understand what the outcome would be here. If we have two instances with the same name, we should print a warning letting the user know we won't be exporting them like we do for other resource (e.g., AADApplication) instead of trying to determine which ones to export or skip.
There was a problem hiding this comment.
I update the PR to support this case.
Now we are using the original groupId (unique) and and use the first display name (are they are all exactly equals).
I think we don't need any warning with this behaviour.
WDYT ?
pkernevez
force-pushed
the
bugfix-may-found-multiple-value
branch
3 times, most recently
from
4917c96 to
5914d7e
Compare
andikrueger
reviewed
Oct 9, 2023
...soft365DSC/DSCResources/MSFT_TeamsGroupPolicyAssignment/MSFT_TeamsGroupPolicyAssignment.psm1
Outdated
Show resolved
Hide resolved
...soft365DSC/DSCResources/MSFT_TeamsGroupPolicyAssignment/MSFT_TeamsGroupPolicyAssignment.psm1
Show resolved
Hide resolved
pkernevez
force-pushed
the
bugfix-may-found-multiple-value
branch
from
4ae53af to
c80dc30
Compare
pkernevez
force-pushed
the
bugfix-may-found-multiple-value
branch
from
c80dc30 to
699f1c5
Compare
NikCharlebois
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Export may found multiple values for CsGroup.DisplayName and CSGroup.GroupId, then creates invalid export
This Pull Request (PR) fixes the following issues
Fixes #3736