Add support for multiple Rank / group in the same configuration. #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, I have see it now, but in #3057 the Groupid is now a Key, this eliminate the possibility to use the same configuration for multiple Tenant using the Group Displayname. |
|
Thank you for this PR and the second look at this issue. I would take the discussion back to the initial issue #3054 and hold both PRs until we do have a common understanding. |
|
We need to make sure that users writing the configuration manually aren't forced providing an ID, which doesn't exist just for configurations to compile. My recommendation is to put #3057 on hold and consider merging this PR here instead. |
|
#3057 was merged. Closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Fix Issue with duplicated Key value in exported configuration
This Pull Request (PR) fixes the following issues
Fixes #3057