Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function Test-M365DSCModuleValidity #2120

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Add function Test-M365DSCModuleValidity #2120

merged 3 commits into from
Jul 20, 2022

Conversation

fldried
Copy link
Contributor

@fldried fldried commented Jul 20, 2022

This cmdlet checks whether or not the Microsoft365DSC Module is up2date and suggests the user to update the module and its dependencies if it isnt.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

this changes the behavior of Test-M365DSCDependenciesForNewVersions by having it return an array of outdated modules, technically this step can be skipped/replaced by just the Update-M365DSCDependencies and Uninstall-M365DSCOutdatedDependencies cmdlets
@fldried fldried requested a review from NikCharlebois as a code owner July 20, 2022 08:20
@ghost
Copy link

ghost commented Jul 20, 2022

CLA assistant check
All CLA requirements met.

@fldried
Copy link
Contributor Author

fldried commented Jul 20, 2022

#2074

@andikrueger
Copy link
Collaborator

Please have a look at my comment within #2074

@fldried fldried marked this pull request as draft July 20, 2022 08:55
@fldried fldried marked this pull request as ready for review July 20, 2022 09:54
Copy link
Collaborator

@NikCharlebois NikCharlebois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NikCharlebois NikCharlebois merged commit 5e44e5b into microsoft:Dev Jul 20, 2022
@fldried fldried deleted the t0w0ru-patch-1 branch July 20, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants