-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXOJournalRule - New Resource #1326
Conversation
@ykuijs Can you please do a code review on this new resource? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments
Reviewed 5 of 8 files at r1, 3 of 3 files at r2.
Reviewable status: 8 of 10 files reviewed, 4 unresolved discussions (waiting on @NikCharlebois and @ykuijs)
Modules/Microsoft365DSC/DSCResources/MSFT_EXOJournalRule/MSFT_EXOJournalRule.psm1, line 226 at r2 (raw file):
if ($Ensure -eq 'Present' -and $currentValues.Ensure -eq 'Absent') { Write-Verbose -Message "Creating new Journal Rule {$Name}"
Maybe add the to be configured value, just like we do in the Set section
"to {$enabledValue}"
Modules/Microsoft365DSC/DSCResources/MSFT_EXOJournalRule/MSFT_EXOJournalRule.psm1, line 244 at r2 (raw file):
if ($Enabled -eq $true) { Write-Host "TADA!!!"
Probably some testing still in here 😄
Modules/Microsoft365DSC/DSCResources/MSFT_EXOJournalRule/MSFT_EXOJournalRule.psm1, line 256 at r2 (raw file):
elseif ($Ensure -eq 'Absent' -and $currentValues.Ensure -eq 'Present') { Remove-JournalRule -Identity $Name | Out-Null
Add Verbose message that the rule will be removed
Modules/Microsoft365DSC/DSCResources/MSFT_EXOJournalRule/MSFT_EXOJournalRule.schema.mof, line 6 at r2 (raw file):
{ [Key, Description("Name of the Journal Rule")] String Name; [Key, Description("The JournalEmailAddress parameter specifies a recipient object to which journal reports are sent. You ean use any value that uniquely identifies the recipient.")] String JournalEmailAddress;
Typo in "You can", ean must be can
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 8 of 10 files reviewed, 4 unresolved discussions (waiting on @ykuijs)
Modules/Microsoft365DSC/DSCResources/MSFT_EXOJournalRule/MSFT_EXOJournalRule.psm1, line 226 at r2 (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
Maybe add the to be configured value, just like we do in the Set section
"to {$enabledValue}"
Done.
Modules/Microsoft365DSC/DSCResources/MSFT_EXOJournalRule/MSFT_EXOJournalRule.psm1, line 244 at r2 (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
Probably some testing still in here 😄
HAHAHAHAHAH. Good find!
Modules/Microsoft365DSC/DSCResources/MSFT_EXOJournalRule/MSFT_EXOJournalRule.psm1, line 256 at r2 (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
Add Verbose message that the rule will be removed
Done.
Modules/Microsoft365DSC/DSCResources/MSFT_EXOJournalRule/MSFT_EXOJournalRule.schema.mof, line 6 at r2 (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
Typo in "You can", ean must be can
Nice this is taking from docs.microsoft.com. I'll send them a PR to fix it up there too. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r3.
Reviewable status: 9 of 10 files reviewed, 1 unresolved discussion (waiting on @ykuijs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @NikCharlebois)
Pull Request (PR) description
Initial Release of EXOJournalRule
This Pull Request (PR) fixes the following issues
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)