Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Integration Tests #1323

Merged
merged 3 commits into from
Jul 16, 2021
Merged

Fixed Integration Tests #1323

merged 3 commits into from
Jul 16, 2021

Conversation

NikCharlebois
Copy link
Collaborator

@NikCharlebois NikCharlebois commented Jul 16, 2021 •
edited by ykuijs
Loading

Pull Request (PR) description

  • AADMSGroup
    • Fixed an issue where the Visibility parameter was never properly returned
      which always threw a detected drift when used.
  • SPOSite
    • Fixed the StorageQuotaWarningLevel value returned by the Get-TargetResource
      function.

This Pull Request (PR) fixes the following issues

N/A

This change is Reviewable

@NikCharlebois NikCharlebois requested a review from desmay July 16, 2021 11:47
desmay
desmay previously approved these changes Jul 16, 2021
View reviewed changes
Copy link
Collaborator

@desmay desmay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @NikCharlebois)

@NikCharlebois NikCharlebois merged commit 044b7e2 into microsoft:Dev Jul 16, 2021
@Jvr2022 Jvr2022 mentioned this pull request Oct 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desmay desmay desmay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikCharlebois @desmay