Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamsTenantDialPlan: Empty Global DialPlan not load NormalizationRules #3767

Closed
abx-mariusdaepp opened this issue Oct 9, 2023 · 0 comments · Fixed by #4118 or #4139
Closed

TeamsTenantDialPlan: Empty Global DialPlan not load NormalizationRules #3767

abx-mariusdaepp opened this issue Oct 9, 2023 · 0 comments · Fixed by #4118 or #4139
Labels
Bug Something isn't working Teams V1.23.1004.1 Version 1.23.1004.1

Comments

@abx-mariusdaepp
Copy link
Contributor

Description of the issue

The Global Policy exist on a new Tenant. But is empty without Normalization Rules. The problem is that an existing Policy without NormalizationRules the Desired NormalizationRules not will be Added.

maby because the function "Get-M365DSCVoiceNormalizationRulesDifference" mandatories the CurrentRules. which are null

See the Logs. After "Tenant Dial Plan {Global} already exists. Updating it." he made no changes.

Microsoft 365 DSC Version

1.23.1004.1

Which workloads are affected

Teams

The DSC configuration

Configuration MasterConfig
{
    param (
    )

    Import-DscResource -ModuleName 'Microsoft365DSC'

    Node localhost
    {
        
        
        TeamsTenantDialPlan TestDialPlan
        {
            ApplicationId             = $ConfigurationData.NonNodeData.ApplicationId;
            CertificateThumbprint     = $ConfigurationData.NonNodeData.CertificateThumbprint;
            TenantId                  = $ConfigurationData.NonNodeData.TenantId;
            Ensure                = "Present";
            Identity              = "Global";
            NormalizationRules    = @(MSFT_TeamsVoiceNormalizationRule{
                Pattern = '^0(900\d*)$'
                Description = ''
                Identity = '0900 Nummern'
                Translation = '+41$1'
                IsInternalExtension = $False
            });
            OptimizeDeviceDialing = $False;
            SimpleName            = "DefaultTenantDialPlan";
        }
        
    }
}
MasterConfig -ConfigurationData .\ConfigurationData.psd1

Verbose logs showing the problem

PS C:\Temp\TestDSC\Export-Config> Start-DSCConfiguration -Path .\MasterConfig -Verbose -Wait
VERBOSE: Perform operation 'Invoke CimMethod' with following parameters, ''methodName' = SendConfigurationApply,'className' = MSFT_DSCLocalConfigurationManager,'namespaceName' = root/Microsoft/Windows/DesiredStateConfiguration'.
VERBOSE: An LCM method call arrived from computer XXX with user sid .
VERBOSE: [XXX]: LCM:  [ Start  Set      ]
VERBOSE: [XXX]: LCM:  [ Start  Resource ]  [[TeamsTenantDialPlan]TestDialPlan]
VERBOSE: [XXX]: LCM:  [ Start  Test     ]  [[TeamsTenantDialPlan]TestDialPlan]
VERBOSE: [XXX]:                            [[TeamsTenantDialPlan]TestDialPlan] Testing configuration of Teams Guest Calling
VERBOSE: [XXX]:                            [[TeamsTenantDialPlan]TestDialPlan] Getting configuration of Teams Tenant Dial Plan
VERBOSE: [XXX]:                            [[TeamsTenantDialPlan]TestDialPlan] Found existing Dial Plan {Global}
VERBOSE: [XXX]:                            [[TeamsTenantDialPlan]TestDialPlan] Current Values: ApplicationId=***
CertificateThumbprint=***
Credential=$null
Description=$null
Ensure=Present
ExternalAccessPrefix=$null
Identity=Global
NormalizationRules=()
OptimizeDeviceDialing=False
SimpleName=DefaultTenantDialPlan
TenantId=***
VERBOSE: [XXX]:                            [[TeamsTenantDialPlan]TestDialPlan] Target Values: ApplicationId=***
CertificateThumbprint=***
Ensure=Present
Identity=Global
NormalizationRules=({Identity=0900 Nummern; Priority=; Description=; Pattern=^0(900\d*)$; Translation=+41$1; IsInternalExtension=False})
OptimizeDeviceDialing=False
SimpleName=DefaultTenantDialPlan
TenantId=***
Verbose=True
VERBOSE: [XXX]: LCM:  [ End    Test     ]  [[TeamsTenantDialPlan]TestDialPlan]  in 0.8920 seconds.
VERBOSE: [XXX]: LCM:  [ Start  Set      ]  [[TeamsTenantDialPlan]TestDialPlan]
VERBOSE: [XXX]:                            [[TeamsTenantDialPlan]TestDialPlan] Setting configuration of Teams Guest Calling
VERBOSE: [XXX]:                            [[TeamsTenantDialPlan]TestDialPlan] Getting configuration of Teams Tenant Dial Plan
VERBOSE: [XXX]:                            [[TeamsTenantDialPlan]TestDialPlan] Found existing Dial Plan {Global}
VERBOSE: [XXX]:                            [[TeamsTenantDialPlan]TestDialPlan] Tenant Dial Plan {Global} already exists. Updating it.
VERBOSE: [XXX]: LCM:  [ End    Set      ]  [[TeamsTenantDialPlan]TestDialPlan]  in 0.8970 seconds.
VERBOSE: [XXX]: LCM:  [ End    Resource ]  [[TeamsTenantDialPlan]TestDialPlan]
VERBOSE: [XXX]: LCM:  [ End    Set      ]
VERBOSE: [XXX]: LCM:  [ End    Set      ]    in  1.9300 seconds.
VERBOSE: Operation 'Invoke CimMethod' complete.
VERBOSE: Time taken for configuration job to complete is 2.097 seconds

Environment Information + PowerShell Version

Name                           Value                                                                                                                                                                                                                            
----                           -----                                                                                                                                                                                                                            
PSVersion                      5.1.17763.2931                                                                                                                                                                                                                   
PSEdition                      Desktop                                                                                                                                                                                                                          
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}                                                                                                                                                                                                          
BuildVersion                   10.0.17763.2931                                                                                                                                                                                                                  
CLRVersion                     4.0.30319.42000                                                                                                                                                                                                                  
WSManStackVersion              3.0                                                                                                                                                                                                                              
PSRemotingProtocolVersion      2.3                                                                                                                                                                                                                              
SerializationVersion           1.1.0.1
@abx-mariusdaepp abx-mariusdaepp changed the title TeamsTenantDialPlan: Empty Global DialPlan TeamsTenantDialPlan: Empty Global DialPlan not load NormalizationRules Oct 9, 2023
@andikrueger andikrueger added Bug Something isn't working Teams V1.23.1004.1 Version 1.23.1004.1 labels Oct 11, 2023
abx-mariusdaepp added a commit to abx-mariusdaepp/Microsoft365DSC that referenced this issue Jan 4, 2024
…-M365DSCVoiceNormalizationRulesDifference. To Load a empty Dial Plan.
NikCharlebois added a commit that referenced this issue Jan 10, 2024
…-3767

Fixes #3767: Remove Mandatory from param CurrentRules in Get-M365DSCVoiceNormalizationRulesDifference. To Load a empty Dial Plan.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Teams V1.23.1004.1 Version 1.23.1004.1
Projects
None yet
2 participants