Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPOAccessControlSettings: Doesn't set CommentsOnSitePagesDisabled #3576

Closed
ghost opened this issue Aug 15, 2023 · 2 comments · Fixed by #4499 or #4512
Closed

SPOAccessControlSettings: Doesn't set CommentsOnSitePagesDisabled #3576

ghost opened this issue Aug 15, 2023 · 2 comments · Fixed by #4499 or #4512
Labels
Breaking Changes Bug Something isn't working SharePoint Online V1.23.809.1 Version 1.23.809.1

Comments

@ghost
Copy link

ghost commented Aug 15, 2023

Details of the scenario you tried and the problem that is occurring

I wan't to enable comments on site pages in SharePoint Online.
Resource SPOAccessControlSettings doesn't set CommentsOnSitePagesDisabled = $False, although Target Values contains correct value (see Verbose logs).

After the configuration is applied, pnp still shows that comments are disabled.

PS C:\> Get-PnPTenant | Select-Object -Property CommentsOnSitePagesDisabled

CommentsOnSitePagesDisabled
---------------------------
                       True

Verbose logs showing the problem

VERBOSE: Perform operation 'Invoke CimMethod' with following parameters, ''methodName' = SendConfigurationApply,'className' = MSFT_DSCLocalConfigurationManager,'namespaceName' = root/Microsoft/Windows/DesiredStateConfiguration'.
VERBOSE: An LCM method call arrived from computer WIN with user sid S-1-5-21-979819412-32789266-2779829992-1000.
VERBOSE: [WIN]: LCM: [ Start Set ]
VERBOSE: [WIN]: LCM: [ Start Resource ] [[SPOAccessControlSettings]SPOAccessControlSettings::[SharePointOnline]Configuration]
VERBOSE: [WIN]: LCM: [ Start Test ] [[SPOAccessControlSettings]SPOAccessControlSettings::[SharePointOnline]Configuration]
VERBOSE: [WIN]: [[SPOAccessControlSettings]SPOAccessControlSettings::[SharePointOnline]Configuration] Testing configuration of SharePoint Online Access Control Settings
VERBOSE: [WIN]: [[SPOAccessControlSettings]SPOAccessControlSettings::[SharePointOnline]Configuration] Getting configuration of SharePoint Online Access Control Settings
VERBOSE: [WIN]: [[SPOAccessControlSettings]SPOAccessControlSettings::[SharePointOnline]Configuration] Current Values: ApplicationId=***
ApplicationSecret=$null
CertificatePassword=$null
CertificatePath=***
CertificateThumbprint=***
CommentsOnSitePagesDisabled=True
Credential=$null
DisallowInfectedFileDownload=False
DisplayStartASiteOption=True
EmailAttestationReAuthDays=30
EmailAttestationRequired=False
Ensure=Present
ExternalServicesEnabled=True
IPAddressAllowList=
IPAddressEnforcement=False
IPAddressWACTokenLifetime=15
IsSingleInstance=Yes
Managedidentity=False
SocialBarOnSitePagesDisabled=False
StartASiteFormUrl=$null
TenantId=***
VERBOSE: [WIN]: [[SPOAccessControlSettings]SPOAccessControlSettings::[SharePointOnline]Configuration] Target Values: ApplicationId=***
CertificateThumbprint=***
CommentsOnSitePagesDisabled=False
DisallowInfectedFileDownload=False
DisplayStartASiteOption=True
EmailAttestationReAuthDays=30
EmailAttestationRequired=False
Ensure=Present
ExternalServicesEnabled=True
IPAddressAllowList=
IPAddressEnforcement=False
IPAddressWACTokenLifetime=15
IsSingleInstance=Yes
SocialBarOnSitePagesDisabled=False
TenantId=***
Verbose=True
VERBOSE: [WIN]: [[SPOAccessControlSettings]SPOAccessControlSettings::[SharePointOnline]Configuration] Test-TargetResource returned False
VERBOSE: [WIN]: LCM: [ End Test ] [[SPOAccessControlSettings]SPOAccessControlSettings::[SharePointOnline]Configuration] in 8.3770 seconds.
VERBOSE: [WIN]: LCM: [ Start Set ] [[SPOAccessControlSettings]SPOAccessControlSettings::[SharePointOnline]Configuration]
VERBOSE: [WIN]: [[SPOAccessControlSettings]SPOAccessControlSettings::[SharePointOnline]Configuration] Setting configuration of SharePoint Online Access Control Settings
VERBOSE: [WIN]: [[SPOAccessControlSettings]SPOAccessControlSettings::[SharePointOnline]Configuration] The IPAddressAllowList is not configured, for that the IPAddressEnforcement parameter can not be set and will be removed
VERBOSE: [WIN]: LCM: [ End Set ] [[SPOAccessControlSettings]SPOAccessControlSettings::[SharePointOnline]Configuration] in 2.3910 seconds.
VERBOSE: [WIN]: LCM: [ End Resource ] [[SPOAccessControlSettings]SPOAccessControlSettings::[SharePointOnline]Configuration]

Suggested solution to the issue

N/A

The DSC configuration that is used to reproduce the issue (as detailed as possible)

 SPOAccessControlSettings "SPOAccessControlSettings" {
        CommentsOnSitePagesDisabled  = $False
        DisallowInfectedFileDownload = $False
        DisplayStartASiteOption      = $True
        EmailAttestationReAuthDays   = 30
        EmailAttestationRequired     = $False
        Ensure                       = "Present"
        ExternalServicesEnabled      = $True
        IPAddressAllowList           = ""
        IPAddressEnforcement         = $False
        IPAddressWACTokenLifetime    = 15
        IsSingleInstance             = "Yes"
        SocialBarOnSitePagesDisabled = $False
        ApplicationId                = $ApplicationId
        TenantId                     = $TenantId
        CertificateThumbprint        = $CertificateThumbprint
    }

The operating system the target node is running

OsName : Microsoft Windows 10 Pro
OsOperatingSystemSKU : 48
OsArchitecture : 64-bit
WindowsVersion : 2009
WindowsBuildLabEx : 19041.1.amd64fre.vb_release.191206-1406
OsLanguage : en-US
OsMuiLanguages : {en-US}

Version of the DSC module that was used ('dev' if using current dev branch)

1.23.809.1

@andikrueger andikrueger added Bug Something isn't working SharePoint Online V1.23.809.1 Version 1.23.809.1 labels Aug 17, 2023
@malauter
Copy link
Member

I cannot reproduce this issue with V.1.23.823.1 in my environment...

@ghost
Copy link
Author

ghost commented Sep 14, 2023

I found out that the parameter 'CommentsOnSitePagesDisabled' is configurable via the resource 'SPOAccessControlSettings' as well as 'SPOTenantSettings'. This creates the conflict in my configuration.

Suggested solution to the issue
Remove the parameter from one of the two resources. -> Breaking Change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Changes Bug Something isn't working SharePoint Online V1.23.809.1 Version 1.23.809.1
Projects
None yet
2 participants