Merge pull request #4299 from NikCharlebois/SCDLPComplianceRule

SCDLPComplianceRule Fancy Quotes Handling
microsoft · Feb 7, 2024 · 3d90887 · 3d90887
2 parents bc6319b + bb0a498
commit 3d90887
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,8 @@
 * IntuneDeviceEnrollmentPlatformRestriction
   * Added Priority parameter
     FIXES [#4081](https://github.com/microsoft/Microsoft365DSC/issues/4081)
+* SCDLPComplianceRule
+  * Properly escapes fancy quotes in the Get method.
 * TeamsMeetingPolicy
   * Ignore the AllowUserToJoinExternalMeeting  parameterfor drift evaluation
     since it doesn't do anything based on official documentation.

diff --git a/Modules/Microsoft365DSC/DSCResources/MSFT_SCDLPComplianceRule/MSFT_SCDLPComplianceRule.psm1 b/Modules/Microsoft365DSC/DSCResources/MSFT_SCDLPComplianceRule/MSFT_SCDLPComplianceRule.psm1
@@ -246,6 +246,7 @@ function Get-TargetResource
                 $ExceptIfContentExtensionMatchesWords = $PolicyRule.ExceptIfContentExtensionMatchesWords.Replace(' ', '').Split(',')
             }
 
+            $fancyDoubleQuotes = "[\u201C\u201D]"
             $result = @{
                 Ensure                                      = 'Present'
                 Name                                        = $PolicyRule.Name
@@ -262,8 +263,8 @@ function Get-TargetResource
                 GenerateIncidentReport                      = $PolicyRule.GenerateIncidentReport
                 IncidentReportContent                       = $ArrayIncidentReportContent
                 NotifyAllowOverride                         = $NotifyAllowOverrideValue
-                NotifyEmailCustomText                       = $PolicyRule.NotifyEmailCustomText
-                NotifyPolicyTipCustomText                   = $PolicyRule.NotifyPolicyTipCustomText
+                NotifyEmailCustomText                       = [regex]::Replace($PolicyRule.NotifyEmailCustomText, $fancyDoubleQuotes, '"')
+                NotifyPolicyTipCustomText                   = [regex]::Replace($PolicyRule.NotifyPolicyTipCustomText, $fancyDoubleQuotes, '"')
                 NotifyUser                                  = $PolicyRule.NotifyUser
                 ReportSeverityLevel                         = $PolicyRule.ReportSeverityLevel
                 RuleErrorAction                             = $PolicyRule.RuleErrorAction