Merge pull request #3088 from Borgquite/patch-2

Remove GroupTypes defaulting to Unified - fixes #3073
microsoft · Mar 30, 2023 · 27f8051 · 27f8051
2 parents d04a7d4 + e08b492
commit 27f8051
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -25,6 +25,8 @@
 * AADGroup
   * Changed the SecurityEnabled and MailEnabled parameters to become mandatory.
     FIXES [#3072](https://github.com/microsoft/Microsoft365DSC/issues/3072)
+  * Stopped GroupTypes defaulting to 'Unified' to allow creation of Security groups.
+    FIXES [#3073](https://github.com/microsoft/Microsoft365DSC/issues/3073)
 * AADUser
   * [BREAKING CHANGE] Remove deprecated parameter PreferredDataLocation* EXOAntiPhishPolicy
   * [BREAKING CHANGE] Remove deprecated parameters EnableAntispoofEnforcement and

diff --git a/Modules/Microsoft365DSC/DSCResources/MSFT_AADGroup/MSFT_AADGroup.psm1 b/Modules/Microsoft365DSC/DSCResources/MSFT_AADGroup/MSFT_AADGroup.psm1
@@ -34,7 +34,7 @@ function Get-TargetResource
 
         [Parameter()]
         [System.String[]]
-        $GroupTypes = @('Unified'),
+        $GroupTypes,
 
         [Parameter()]
         [System.String]
@@ -402,10 +402,6 @@ function Set-TargetResource
         Write-Verbose -Message 'Cannot set mailenabled to false if GroupTypes is set to Unified when creating group.'
         throw 'Cannot set mailenabled to false if GroupTypes is set to Unified when creating a group.'
     }
-    if (-not $GroupTypes -and $currentParameters.GroupTypes -eq $null)
-    {
-        $currentParameters.Add('GroupTypes', @('Unified'))
-    }
 
     $currentValuesToCheck = @()
     if ($currentGroup.AssignedLicenses.Length -gt 0)