Report better version for VS preview consoles #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For prereleases, the Visual Studio command prompt sets the environment variable `VSCMD_VER` to a value like `15.7.0-pre.3.0`, which is not parseable by System.Version. This could be handled by using a version parser that can handle this SemVer 2 version as well as Windows 4-part versions, but that would be another dependency, so I just special-cased the problematic dash.
|
example before: after: |
DustinCampbell
approved these changes
Apr 18, 2018
AndyGerlicher
approved these changes
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For prereleases, the Visual Studio command prompt sets the environment
variable
VSCMD_VERto a value like15.7.0-pre.3.0, which is notparseable by System.Version.
This could be handled by using a version parser that can handle this
SemVer 2 version as well as Windows 4-part versions, but that would be
another dependency, so I just special-cased the problematic dash.